Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/tip: migrate beta.golang.org to tip GKE service #25978

Closed
bradfitz opened this issue Jun 20, 2018 · 4 comments
Closed

x/build/cmd/tip: migrate beta.golang.org to tip GKE service #25978

bradfitz opened this issue Jun 20, 2018 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

beta.golang.org runs on a GCE VM in a somewhat ad-hoc config.

Now that tip.golang.org on GKE is stable (I think?), let's nuke the weird VM and just make tip.golang.org and beta.golang.org have the same IP and be served by the same place.

The difference between betas and tip is always tiny anyway, and there's basically never a case where we want beta.golang.org to serve something older than tip. If anything, it's been tedious logging into beta.golang.org regularly during the beta/rc cycle and running "git pull" and restarting systemd services when needed.

/cc @FiloSottile @bcmills
@bradfitz bradfitz self-assigned this Jun 20, 2018
@gopherbot gopherbot added this to the Unreleased milestone Jun 20, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jun 20, 2018
@bradfitz bradfitz changed the title x/build/cmd/tip: migrate beta.golang.org to tip GKE service x/tools/cmd/tip: migrate beta.golang.org to tip GKE service Jun 20, 2018
@gopherbot
Copy link

Change https://golang.org/cl/120056 mentions this issue: cmd/tip: support also serving beta.golang.org

@dmitshur
Copy link
Contributor

dmitshur commented Jun 20, 2018 •
edited

I have some comments/questions to understand this better. I'm not against this, you're in a better position to know if the work maintaining beta isn't justified.

If I understand this issue, once resolved, tip and beta will both always serve the exact same Go version, is that right?

The difference between betas and tip is always tiny anyway, and there's basically never a case where we want beta.golang.org to serve something older than tip.

My understanding of beta was that it's supposed to be the latest beta or RC release, whereas tip is latest master branch commit. Sometimes it's helpful to be able to compare the two (and link to them). But it sounds like that's not what it actually was...

FWIW, there were a few times in the last few years when tip was broken (for a few hours) but I could fall back to beta in the meantime. It's certainly rare though.

If my understanding is right and the plan is to have tip and beta always serve the exact same version, why not just drop beta completely and leave only tip?

@bradfitz
Copy link
Contributor Author

If my understanding is right and the plan is to have tip and beta always serve the exact same version, why not just drop beta completely and leave only tip?

That's effectively what we're doing, but we're redirecting beta.golang.org URLs to tip.golang.org so we don't break any links.

gopherbot pushed a commit to golang/tools that referenced this issue Oct 17, 2018
@bradfitz
cmd/tip: make tip.golang.org also serve & redirect beta.golang.org to…
4cdd33f 
… tip

We're turning down the old (and neglected) beta.golang.org godoc VM.
It's not different enough from tip.golang.org, which is more reliable
than it used to be.

Now beta.golang.org will just redirect to tip.

Updates golang/go#25978
Fixes golang/go#21073

Change-Id: Iae7fe4c82c14cec7381e75a2e214210d38b6e623
Reviewed-on: https://go-review.googlesource.com/c/120056
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@bradfitz
Copy link
Contributor Author

This is done.

@dmitshur dmitshur changed the title x/tools/cmd/tip: migrate beta.golang.org to tip GKE service x/build/cmd/tip: migrate beta.golang.org to tip GKE service Feb 1, 2019
@golang golang locked and limited conversation to collaborators Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @dmitshur @gopherbot