Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/build: Context.CgoEnabled comment meaning unclear #25953

Closed
willfaught opened this issue Jun 19, 2018 · 1 comment
Closed

go/build: Context.CgoEnabled comment meaning unclear #25953

willfaught opened this issue Jun 19, 2018 · 1 comment
Labels
Documentation FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.12

Comments

@willfaught
Copy link
Contributor

CgoEnabled bool // whether cgo can be used

It's unclear whether this means using a Context where CgoEnabled is false on a package that uses cgo would result in an error, or would omit all the files from go/build.Package.CgoFiles.

What version of Go are you using (go version)?

https://golang.org/pkg/go/build/#Context

Does this issue reproduce with the latest release?

Yes
@ianlancetaylor ianlancetaylor added Documentation help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Jun 19, 2018
@ianlancetaylor ianlancetaylor added this to the Go1.12 milestone Jun 19, 2018
@gopherbot
Copy link

Change https://golang.org/cl/126736 mentions this issue: go/build: Context.CgoEnabled is better commented

@golang golang locked and limited conversation to collaborators Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
3 participants
@willfaught @ianlancetaylor @gopherbot