Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: many tests failing due to ENOSYS Pipe on js,wasm #25913

Closed
bradfitz opened this issue Jun 15, 2018 · 4 comments
Closed

syscall: many tests failing due to ENOSYS Pipe on js,wasm #25913

bradfitz opened this issue Jun 15, 2018 · 4 comments
Labels
arch-wasm WebAssembly issues FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone

Comments

@bradfitz
Copy link
Contributor

https://build.golang.org/log/bf6cae84b57c5946f94da6f3291cb90281882f34

On js/wasm, syscall/fs_js.go is:

func Pipe(fd []int) error {
        return ENOSYS
}

That causes many tests to fail.

I thought we were going to use the nacl code here? Did too much of that get ripped out?

/cc @neelance

@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. release-blocker arch-wasm WebAssembly issues labels Jun 15, 2018
@bradfitz bradfitz added this to the Go1.11 milestone Jun 15, 2018
@neelance
Copy link
Member

I thought we were going to use the nacl code here? Did too much of that get ripped out?

The eventual decision was to remove all FD mapping logic and to use FDs given by Node.js directly. Since Node.js has no support for os.Pipe, it had to become unsupported. (Discussion on https://go-review.googlesource.com/c/go/+/109977)

I skipped tests that depend on os.Pipe. However, I'm always running tests with -short, since wasm is terribly slow on the tests that are already considered slow on other architectures. I guess that the failures you see are tests that are not -short.

@bradfitz
Copy link
Contributor Author

all.bash runs tests with -short.

@neelance
Copy link
Member

Found it: What I am also using is -run=Test to exclude Example*. Running examples depends on os.Pipe:

r, w, err := os.Pipe()
if err != nil {
fmt.Fprintln(os.Stderr, err)
os.Exit(1)
}
os.Stdout = w

@gopherbot
Copy link

Change https://golang.org/cl/119377 mentions this issue: cmd/dist: don't test Examples for js/wasm

@golang golang locked and limited conversation to collaborators Jun 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly issues FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants