-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/dist: don't build tools for wasm build #25911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I get this -
What am I missing ? |
@agnivade, that's the complete output? I don't see how that's possible. There are |
Figured it out. It is this line which runs before the
I am using Go1.10 to bootstrap. Hence it does not support Also, how do I run tests ? I see this -
Obviously wasm won't run natively. Do I need to use |
I'm bootstrapping with Go 1.4, but make.bash works for me. What is your complete output of make.bash when it fails and what is your environment? Yes, you need go_js_wasm_exec in your $PATH, and you need nodejs installed to run the "node" binary. |
That is it :)
linux/amd64. Ubuntu 16.04. Just guessing, but probably 1.4 does not have an explicit whitelist of GOOS/GOARCH pairs like 1.10 ?
Ah gotcha. |
You didn't answer the question about what is in your environment. Do you define GOROOT_BOOTSTRAP?
Might be related, but I can build js/wasm with go1.10:
|
Ah, by environment, you meant environment variables. No I am not defining GOROOT_BOOTSTRAP. And by explicitly defining it, it works because it bypasses that check on L144 :)
Thank you for helping me debug this. |
@agnivade, want to resume work on this now? |
Yea I had. But faced minor bumps while persevering through the code. I can see that the |
Change https://golang.org/cl/120655 mentions this issue: |
When running make.bash for GOOS=js GOARCH=wasm, we build a bunch of never-used tools (dist, api, gofmt, etc).
Low priority, but look into skipping those to save time/space.
Okay for Go 1.11 if somebody wants to do it, but marking Unplanned.
/cc @neelance
The text was updated successfully, but these errors were encountered: