x/crypto/acme/autocert: NewListener does not acquire new certificates #25901
Labels
Milestone
Comments
|
Re: fulfill the role of autocert.Manager.HttpHandler. There's a whole discussion about this in the related issue you referenced. Note that tls-alpn is coming, at which point http won't be required anymore, again. See #25013 for details. |
|
That sounds like a good plan, although I don't understand the details well enough to have a qualified opinion here. However, until this works in practice, there needs to be at least a note in the documentation, because right now it simply doesn't work as advertised. This stuff is too complex to hope that all users just know what they have to do from the logged warnings. |
|
Change https://golang.org/cl/125495 mentions this issue: |
c-expert-zigbee
pushed a commit
to c-expert-zigbee/crypto_go
that referenced
this issue
Mar 28, 2022
Because tls.Config now requires more fields to be set in order for tls-alpn to work, Manager provides a new TLSConfig method for easier setup. This CL also adds a new internal package for end-to-end tests. The package implements a simple ACME CA server. Fixes golang/go#25013 Fixes golang/go#25901 Updates golang/go#17251 Change-Id: I2687ea8d5c445ddafad5ea2cdd36cd4e7d10bc86 Reviewed-on: https://go-review.googlesource.com/125495 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
c-expert-zigbee
pushed a commit
to c-expert-zigbee/crypto_go
that referenced
this issue
Mar 29, 2022
Because tls.Config now requires more fields to be set in order for tls-alpn to work, Manager provides a new TLSConfig method for easier setup. This CL also adds a new internal package for end-to-end tests. The package implements a simple ACME CA server. Fixes golang/go#25013 Fixes golang/go#25901 Updates golang/go#17251 Change-Id: I2687ea8d5c445ddafad5ea2cdd36cd4e7d10bc86 Reviewed-on: https://go-review.googlesource.com/125495 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
c-expert-zigbee
pushed a commit
to c-expert-zigbee/crypto_go
that referenced
this issue
Mar 29, 2022
Because tls.Config now requires more fields to be set in order for tls-alpn to work, Manager provides a new TLSConfig method for easier setup. This CL also adds a new internal package for end-to-end tests. The package implements a simple ACME CA server. Fixes golang/go#25013 Fixes golang/go#25901 Updates golang/go#17251 Change-Id: I2687ea8d5c445ddafad5ea2cdd36cd4e7d10bc86 Reviewed-on: https://go-review.googlesource.com/125495 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
LewiGoddard
pushed a commit
to LewiGoddard/crypto
that referenced
this issue
Feb 16, 2023
Because tls.Config now requires more fields to be set in order for tls-alpn to work, Manager provides a new TLSConfig method for easier setup. This CL also adds a new internal package for end-to-end tests. The package implements a simple ACME CA server. Fixes golang/go#25013 Fixes golang/go#25901 Updates golang/go#17251 Change-Id: I2687ea8d5c445ddafad5ea2cdd36cd4e7d10bc86 Reviewed-on: https://go-review.googlesource.com/125495 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
BiiChris
pushed a commit
to BiiChris/crypto
that referenced
this issue
Sep 15, 2023
Because tls.Config now requires more fields to be set in order for tls-alpn to work, Manager provides a new TLSConfig method for easier setup. This CL also adds a new internal package for end-to-end tests. The package implements a simple ACME CA server. Fixes golang/go#25013 Fixes golang/go#25901 Updates golang/go#17251 Change-Id: I2687ea8d5c445ddafad5ea2cdd36cd4e7d10bc86 Reviewed-on: https://go-review.googlesource.com/125495 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Using
log.Fatal(http.Serve(autocert.NewListener("example.com"), handler))as described by the documentation does not allow the server to acquire new certificates anymore, since Let's Encrypt disabled tls-sni-* validation.This limitation should either be documented or the function removed. Could the listener be changed to listen to both http and https at the same time, so it can fulfill the role of autocert.Manager.HttpHandler as well?
Related: #21890
The text was updated successfully, but these errors were encountered: