cmd/go: maybe show legacy tags in pseudoversions #25898
Labels
modules
NeedsDecision
Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Comments
|
Particularly useful if you're using branches during active development. |
rsc
changed the title
|
I'm not going to do this for Go 1.11. I think it's important not to clutter the pseudo-version with non-essential information, so that there is always a single canonical form in all the things that print versions. For Go 1.12 maybe we can find a way to put it in a comment instead. |
rsc
added
the
NeedsDecision
This was referenced May 13, 2019
|
We could also retain the original |
|
If it'll live in the version string not in a comment, note that git tags, branches etc can contain slashes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you do
where tag is not a proper semver tag for foo, then vgo looks up tag, resolves the commit, finds the date on the commit, and records instead of tag a pseudo-version like
I wonder if we should preserve the tag, so that the recorded version would be:
This would work for branch names and legacy semver tags too, of course, so that we could have:
These would just show a little bit more information when you list your dependencies in projects not using tagged releases (or at least vgo-compatible tagged releases in the case of the legacy v17).
The text was updated successfully, but these errors were encountered: