Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/pprof: TestMapping failures on linux-arm-arm5spacemonkey builder #25891

Closed
ALTree opened this issue Jun 14, 2018 · 2 comments
Closed

runtime/pprof: TestMapping failures on linux-arm-arm5spacemonkey builder #25891

ALTree opened this issue Jun 14, 2018 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.11

Comments

@ALTree
Copy link
Member

ALTree commented Jun 14, 2018 •
edited

The linux-arm-arm5spacemonkey builder was previously broken by a debug/gosym test, but aclements fixed it and now it's failing a little later on the recently introduced TestMapping test from runtime/pprof.

Builder log:
https://build.golang.org/log/84f2e315572ca0987ae2da0394bcecdddcf2aaa1

Change that introduced the test:
https://go-review.googlesource.com/c/go/+/118275

cc @hyangah
@ALTree ALTree added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 14, 2018
@ALTree ALTree added this to the Go1.11 milestone Jun 14, 2018
@hyangah
Copy link
Contributor

hyangah commented Jun 14, 2018

assumption in the test (there will be only one entry for the main binary) is wrong.

1: 0x10000/0x162000/0x0 /home/builder/stage0scratch/tmp/go-build662113649/b001/exe/main 50f7cd36fd06f7cd6b5ccb333913714322dba361 [FN]
2: 0x171000/0x182000/0x151000 /home/builder/stage0scratch/tmp/go-build662113649/b001/exe/main 50f7cd36fd06f7cd6b5ccb333913714322dba361

Fixing the test.

@ALTree ALTree added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 15, 2018
@gopherbot
Copy link

Change https://golang.org/cl/119455 mentions this issue: runtime/pprof: fix incorrect assumption in TestMapping

@golang golang locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
3 participants
@ALTree @hyangah @gopherbot