Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/nm: TestGoExec failing on Plan 9 #25820

Closed
0intro opened this issue Jun 11, 2018 · 4 comments
Closed

cmd/nm: TestGoExec failing on Plan 9 #25820

0intro opened this issue Jun 11, 2018 · 4 comments
Labels
FrozenDueToAge OS-Plan9
Milestone
Go1.11

Comments

@0intro
Copy link
Member

0intro commented Jun 11, 2018 •
edited

CL 115975 changed TestGoExec. This test is now failing on Plan 9.

--- FAIL: TestGoExec (1.49s)
    nm_test.go:161: want R type for runtime.epclntab symbol, but have D
    nm_test.go:161: want R type for runtime.erodata symbol, but have D
    nm_test.go:161: want R type for runtime.rodata symbol, but have D
FAIL
FAIL	cmd/nm	4.320s

See https://build.golang.org/log/b4bb61cd5942848398474e07807984e34817bceb
@0intro 0intro self-assigned this Jun 11, 2018
@0intro 0intro added this to the Go1.11 milestone Jun 11, 2018
@0intro
Copy link
Member Author

0intro commented Jun 11, 2018

CC @alexbrainman

@alexbrainman
Copy link
Member

Sorry about braking plan9 builder. I did not even noticed.

--- FAIL: TestGoExec (1.49s)
nm_test.go:161: want R type for runtime.epclntab symbol, but have D
nm_test.go:161: want R type for runtime.erodata symbol, but have D
nm_test.go:161: want R type for runtime.rodata symbol, but have D
FAIL

It probably is not important if runtime.epclntab (and others) is "R" or "D". I do not know.

Maybe adjust the test to expect "D" for runtime.epclntab on plan9? Maybe just skip that part of the test?

I will let you decide.

Alex

@0intro
Copy link
Member Author

0intro commented Jun 11, 2018

I think it should be fine if we expect "D" runtime.epclntab on Plan 9.

@gopherbot
Copy link

Change https://golang.org/cl/118035 mentions this issue: cmd/nm: fix TestGoExec on Plan 9

@golang golang locked and limited conversation to collaborators Jun 11, 2019
@rsc rsc unassigned 0intro Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Plan9
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
3 participants
@0intro @gopherbot @alexbrainman