Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/windows: introduce Pointer type and use it instead of uintptr #25797

Closed
perillo opened this issue Jun 8, 2018 · 5 comments
Closed

x/sys/windows: introduce Pointer type and use it instead of uintptr #25797

perillo opened this issue Jun 8, 2018 · 5 comments
Labels
FrozenDueToAge OS-Windows
Milestone
Unreleased

Comments

@perillo
Copy link
Contributor

perillo commented Jun 8, 2018

Commit 4869ec0 (syscall: introduce Pointer type and use it instead of uintptr) has not been backported to the golang/x/sys/windows package.

I don't know if this is an oversight or a feature.
@gopherbot gopherbot added this to the Unreleased milestone Jun 8, 2018
@bcmills
Copy link
Contributor

bcmills commented Jun 8, 2018

CC: @aclements (commit author); @alexbrainman and @bradfitz for sys/windows.

This is closely tied to #24820.

@alexbrainman
Copy link
Member

We need to careful about using newly introduced in go1.11 syscall.Pointer in golang.org/x/sys/windows package. Some people might decide to build the package with previous versions of Go, and that will fail.

Otherwise we should fix golang.org/x/sys/windows too.

Alex

@bcmills
Copy link
Contributor

bcmills commented Jun 9, 2018

Perhaps a type alias with a build constraint would be appropriate?

@alexbrainman
Copy link
Member

Perhaps a type alias with a build constraint would be appropriate?

I just copied code from CL 106275. Hopefully this works for you too.

Alex

@gopherbot
Copy link

Change https://golang.org/cl/118797 mentions this issue: windows: replace uintptr in crypto structs

@golang golang locked and limited conversation to collaborators Jun 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Windows
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bcmills @perillo @gopherbot @alexbrainman