Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: panic: branch too far on arm64 [1.10 backport] #25794

Closed
gopherbot opened this issue Jun 8, 2018 · 3 comments
Closed

cmd/compile: panic: branch too far on arm64 [1.10 backport] #25794

gopherbot opened this issue Jun 8, 2018 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.10.5

Comments

@gopherbot
Copy link

@bronze1man requested issue #23889 to be considered for backport to the next 1.10 minor release.

@gopherbot please consider this for backport to 1.10. I just come cross this bug in my ios project.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 8, 2018
@gopherbot gopherbot mentioned this issue Jun 8, 2018
Closed
@gopherbot gopherbot added this to the Go1.10.4 milestone Jun 8, 2018
@andybons andybons modified the milestones: Go1.10.4, Go1.10.5 Aug 24, 2018
@gopherbot
Copy link
Author

Change https://golang.org/cl/147057 mentions this issue: [release-branch.go1.10] cmd/internal/obj/arm64: fix branch-too-far with TBZ like instructions

@dmitshur
Copy link
Contributor

dmitshur commented Nov 2, 2018

Accepted because it's affecting all of arm64, not just iOS, it's a regression compared to 1.9.x. And it looks like a small, targeted fix for a serious problem.

@gopherbot
Copy link
Author

Closed by merging ce842c5 to release-branch.go1.10.

gopherbot pushed a commit that referenced this issue Nov 2, 2018
@cherrymui @dmitshur
[release-branch.go1.10] cmd/internal/obj/arm64: fix branch-too-far wi…
ce842c5 
…th TBZ like instructions

The compiler now emits TBZ like instructions, but the assembler's
too-far-branch patch code didn't include that case. Add it.

Updates #23889
Fixes #25794

Change-Id: Ib75f9250c660b9fb652835fbc83263a5d5073dc5
Reviewed-on: https://go-review.googlesource.com/94902
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
(cherry picked from commit 911839c)
Reviewed-on: https://go-review.googlesource.com/c/147057
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators Nov 2, 2019
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases Proposal-Accepted labels Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.10.5
Development

No branches or pull requests
3 participants
@andybons @dmitshur @gopherbot