Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestBinaryOnlyPackages broken #25784

Closed
bradfitz opened this issue Jun 7, 2018 · 4 comments
Closed

cmd/go: TestBinaryOnlyPackages broken #25784

bradfitz opened this issue Jun 7, 2018 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.11

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Jun 7, 2018

Test flake in https://storage.googleapis.com/go-build-log/ab26aac8/linux-amd64_5812f616.log

--- FAIL: TestBinaryOnlyPackages (0.02s)
    go_test.go:4232: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
    go_test.go:4232: standard output:
    go_test.go:4232: true:missing or invalid binary-only package
        
    go_test.go:4232: standard error:
    go_test.go:4232: go build p1: missing or invalid binary-only package
        
    go_test.go:4232: go [list -f {{.Stale}}:{{.StaleReason}} p1] failed unexpectedly: exit status 1
FAIL
FAIL	cmd/go	106.462s

Failed on one trybot but passed on all the rest, and passed locally.

I didn't investigate.
@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Jun 7, 2018
@bradfitz bradfitz added this to the Go1.11 milestone Jun 7, 2018
@bradfitz bradfitz changed the title cmd/go: TestBinaryOnlyPackages flake cmd/go: TestBinaryOnlyPackages broken Jun 7, 2018
@bradfitz
Copy link
Contributor Author

bradfitz commented Jun 7, 2018

Nevermind, that's a real failure just introduced at tip, showing across https://build.golang.org/.

It's a non-short test that's run on a number of builders.

@rsc, can you fix?

@bradfitz bradfitz added the Soon This needs to be done soon. (regressions, serious bugs, outages) label Jun 7, 2018
@bcmills
Copy link
Contributor

bcmills commented Jun 7, 2018

git bisect confirms that it broke at https://golang.org/cl/108156.

@gopherbot
Copy link

Change https://golang.org/cl/117075 mentions this issue: cmd/go: skip TestBinaryOnlyPackages until it's fixed

gopherbot pushed a commit that referenced this issue Jun 7, 2018
@bradfitz
cmd/go: skip TestBinaryOnlyPackages until it's fixed
0e1517c 
Updates #25784

Change-Id: I638eab82b026d3df89da532b5cc3f5c06b02d6c8
Reviewed-on: https://go-review.googlesource.com/117075
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/117036 mentions this issue: cmd/go: restore "go list" exit code for missing binary packages

@golang golang locked and limited conversation to collaborators Jun 7, 2019
@rsc rsc unassigned rsc and bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
4 participants
@bradfitz @rsc @bcmills @gopherbot