Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/net/textproto/reader.go alter c/CanonicalMIMEHeaderKey #25782

Closed
wants to merge 1 commit into from
Closed

/net/textproto/reader.go alter c/CanonicalMIMEHeaderKey #25782

wants to merge 1 commit into from

Conversation

YankunLi
Copy link

@YankunLi YankunLi commented Jun 7, 2018

Each header field consists of a case-insensitive field name
followed by a colon (":"), optional leading whitespace, the
field value, and optional trailing whitespace.

This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.

Please ensure you adhere to every item in this list.

More info can be found at https://github.com/golang/go/wiki/CommitMessage

  • The PR title is formatted as follows: net/http: frob the quux before blarfing
    • The package name goes before the colon
    • The part after the colon uses the verb tense + phrase that completes the blank in,
      "This change modifies Go to ___________"
    • Lowercase verb after the colon
    • No trailing period
    • Keep the title as short as possible. ideally under 76 characters or shorter
  • No Markdown
  • The first PR comment (this one) is wrapped at 76 characters, unless it's
    really needed (ASCII art, table, or long link)
  • If there is a corresponding issue, add either Fixes #1234 or Updates #1234
    (the latter if this is not a complete fix) to this comment
  • If referring to a repo other than golang/go you can use the
    owner/repo#issue_number syntax: Fixes golang/tools#1234
  • We do not use Signed-off-by lines in Go. Please don't add them.
    Our Gerrit server & GitHub bots enforce CLA compliance instead.
  • Delete these instructions once you have read and applied them

@YankunLi
/net/textproto/reader.go alter c/CanonicalMIMEHeaderKey
04d6e4e 
Each header field consists of a case-insensitive field name
followed by a colon (":"), optional leading whitespace, the
field value, and optional trailing whitespace.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Jun 7, 2018
@gopherbot gopherbot force-pushed the master branch 13 times, most recently from 4016de0 to d2f663c Compare July 18, 2018 19:56
@gopherbot gopherbot force-pushed the master branch 10 times, most recently from 9092511 to 95c3348 Compare July 19, 2018 18:17
@gopherbot gopherbot force-pushed the master branch 4 times, most recently from 0090c13 to 8fbbf63 Compare July 28, 2018 01:16
@gopherbot gopherbot force-pushed the master branch 2 times, most recently from 0090c13 to 8fbbf63 Compare July 28, 2018 01:16
@YankunLi
Copy link
Author

@googlebot thanks，I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Mar 22, 2019
@gopherbot
Copy link

This PR (HEAD: 04d6e4e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/168802 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/168802.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 1: Code-Review-2

This seems wrong and doesn't come with any explanation of why you'd change this.

Sorry, I'm going to close this.

Please don’t reply on this GitHub thread. Visit golang.org/cl/168802.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR is being closed because golang.org/cl/168802 has been abandoned.

@gopherbot gopherbot closed this Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YankunLi @googlebot @gopherbot