Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types: remove internal flag useCycleMarking, explicit path parameter #25773

Closed
griesemer opened this issue Jun 7, 2018 · 2 comments
Closed

go/types: remove internal flag useCycleMarking, explicit path parameter #25773

griesemer opened this issue Jun 7, 2018 · 2 comments
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.12

Comments

@griesemer
Copy link
Contributor

griesemer commented Jun 7, 2018 •
edited

Reminder issue to remove this flag and the respective dead code (when flag is enabled) after release of 1.11. Also, remove the explicit path parameter for cycle tracking (and handle non-package-level cycles).

(The flag was introduced to guard some complex cycle detection code during the freeze so that it's possible to quickly 'undo' those changes if need be.)
@griesemer griesemer added NeedsFix The path to resolution is known, but the work has not been done. early-in-cycle A change that should be done early in the 3 month dev cycle. labels Jun 7, 2018
@griesemer griesemer added this to the Go1.12 milestone Jun 7, 2018
@griesemer griesemer self-assigned this Jun 7, 2018
@griesemer griesemer changed the title go/types: remove internal flag useCycleMarking go/types: remove internal flag useCycleMarking, explicit path parameter Jun 7, 2018
@griesemer griesemer mentioned this issue Aug 20, 2018
Closed
@gopherbot
Copy link

Change https://golang.org/cl/130455 mentions this issue: go/types: track local cycles using same mechanism as for global objects

@gopherbot
Copy link

Change https://golang.org/cl/130476 mentions this issue: go/types: remove explicit path parameter from most type-checker functions (cleanup)

gopherbot pushed a commit that referenced this issue Aug 30, 2018
@griesemer
go/types: track local cycles using same mechanism as for global objects
ce2e883 
For Go 1.11, cycle tracking of global (package-level) objects was changed
to use a Checker-level object path rather than relying on the explicit
path parameter that is passed around to some (but not all) type-checker
functions.

This change now uses the same mechanism for the detection of local
type cycles (local non-type objects cannot create cycles by definition
of the spec).

As a result, local alias cycles are now correctly detected as well
(issue #27106).

The path parameter that is explicitly passed around to some type-checker
methods is still present and will be removed in a follow-up CL.

Also:
- removed useCycleMarking flag and respective dead code
- added a couple more tests
- improved documentation

Fixes #27106.
Updates #25773.

Change-Id: I7cbf304bceb43a8d52e6483dcd0fa9ef7e1ea71c
Reviewed-on: https://go-review.googlesource.com/130455
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>
@golang golang locked and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
2 participants
@griesemer @gopherbot