-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/cover: html renderer shows misleading coverage #25767
Comments
/cc @ianlancetaylor , @rsc Marking as release blocker because this seems to be a regression. |
@dsymonds Is this due to your recent change? |
It certainly sounds like 4fe688c, which fixed a different instance of segment boundaries at the same place being in the wrong order. |
I've got some of the state still in my head; let me see if I can fix this. |
Change https://golang.org/cl/116975 mentions this issue: |
Change https://golang.org/cl/116976 mentions this issue: |
This adds a case for what was fixed in 4fe688c to prevent regression; a follow-on change will address #25767. Change-Id: Iced8cc10e2993ef7caf7e9c59ffbc7147d78ddd7 Reviewed-on: https://go-review.googlesource.com/116975 Run-TryBot: David Symonds <dsymonds@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
What version of Go are you using (
go version
)?go version devel +db49f76dc5 Tue Jun 5 20:31:21 2018 +0000 linux/amd64
Does this issue reproduce with the latest release?
no, 1.10.2 works fine
What operating system and processor architecture are you using (
go env
)?GOARCH="amd64"
GOHOSTARCH="amd64"
GOHOSTOS="linux"
What did you do?
With the following package:
==> local/x/x.go <==
==> local/x/x_test.go <==
Run the following commands:
What did you expect to see?
A code listing showing which statements have been executed.
What did you see instead?
A code listing showing that all statements have been executed.
The relevant snippet of HTML shows:
Using 1.10.2 the equivalent snippet is:
The text was updated successfully, but these errors were encountered: