Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: can remove function 'cleanHost'? #25754

Closed
Luanana opened this issue Jun 6, 2018 · 2 comments
Closed

net/http: can remove function 'cleanHost'? #25754

Luanana opened this issue Jun 6, 2018 · 2 comments

Comments

@Luanana
Copy link

Luanana commented Jun 6, 2018

func cleanHost(in string) string {

I want to make a tool to test http host inject, but the host header content can't have space or /.

@agnivade
Copy link
Contributor

agnivade commented Jun 6, 2018

We cannot make changes like that because it will break existing code for everybody. If you want to suggest something new, it typically needs to go through the proposal process. See https://golang.org/s/proposal.

You can however, create a low-level net.Listener object and manually go through http headers if you need access to raw data.

@bcmills
Copy link
Contributor

bcmills commented Jun 7, 2018

As @agnivade notes, an API change should go through the proposal process. I'm not sure there's anything more to be done about this issue, but please let me know if I've missed something.

@bcmills bcmills closed this as completed Jun 7, 2018
@golang golang locked and limited conversation to collaborators Jun 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants