-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: cannot import "./package" on Windows #25693
Comments
We probably shouldn't have done cleanups like this during the freeze. Maybe @ianlancetaylor and I just really want to see this dependency gone. How about we revert on Tuesday (US/Pacific) if it's not fixed before then? |
I'm okay with revert on that date. Ping @alexbrainman, maybe he can lend me a hand and give a hint with this bug. |
Before the CL in question (https://golang.org/cl/115277) we did not run the test on Windows, so let's just go back to not running the test on Windows. The test is failing for reasons that are unrelated to the point of the test. There is nothing OS-specific about this test, so skipping it on Windows doesn't seem like a big deal. |
Change https://golang.org/cl/115857 mentions this issue: |
I agree with @ianlancetaylor on this. Fixing this test might be not easy, and disabling it on Windows is not a regression too. Pushed the CL. This ticket is a TODO to enable on Windows. |
Before the CL 115277 we did not run the test on Windows, so let's just go back to not running the test on Windows. There is nothing OS-specific about this test, so skipping it on Windows doesn't seem like a big deal. Updates #25693 Fixes #25586 Change-Id: I1eb3e158b322d73e271ef388f8c6e2f2af0a0729 Reviewed-on: https://go-review.googlesource.com/115857 Run-TryBot: Yury Smolsky <yury@smolsky.by> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Me too. :-)
I will investigate this issue when I have some free time. Thank you for making builders green. Alex |
Hello there @ysmolsky @bradfitz @ianlancetaylor @alexbrainman, should we move |
Sorry, I forgotten about this issue. If I make this change diff --git a/test/fixedbugs/bug345.go b/test/fixedbugs/bug345.go
index b974a61ffb..04c28ce857 100644
--- a/test/fixedbugs/bug345.go
+++ b/test/fixedbugs/bug345.go
@@ -1,4 +1,3 @@
-// +build !windows
// errorcheckdir -n
// Copyright 2011 The Go Authors. All rights reserved.
@@ -6,5 +5,3 @@
// license that can be found in the LICENSE file.
package ignored
-
-// TODO(ysmolsky): Fix golang.org/issue/25693 to enable on Windows.
to f70bd91 and run this command
I can see the error. But I am not familiar enough with how compiler works. The source file does not have any imports containing
So compiler must be replacing
with
Is that valid? If it is valid thing to do, then compiler should be able to handle Windows paths like Alex |
While investigating another . related issue on Windows, it appeared that this test is now successful.
|
Change https://go.dev/cl/395258 mentions this issue: |
Test cannot import dotted package which was compiled in local directory.
Reproduce in Windows:
Specifically it can be reproduced by following sequence:
I do not have an access to dev env in Windows so I cannot investigate any further.
@bradfitz Should I disable the test for Windows until the fix is found or should I revert the original CL completely?
The text was updated successfully, but these errors were encountered: