New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/vgo: modconv doesn't retain "replace" directive information on conversion to go.mod #25692
Comments
|
sorry I didn't understand your point. Are you saying that parsing govendor files won't be supported? |
@krasi-georgiev Sorry for my poor English, |
What is origin? It looks like when a well-known repository path on disk is overwritten by a fork but keeps the well known path in the import declarations. I have encountered this practice a few times and it is very confusing for people to decipher what is going on. It reminds me of the chaos caused by symbolic links sometimes. |
as per my original description this is the master branch of the Prometheus repo so it is the govendor file from there |
In vgo package modconv, the vjson.go file is missing support for reading the Origin field present in govendor vendor/vendor.json files. This should translate to a replace directive in the go.mod file. This is issue is a request to maintain that information when converting the vendor.json file to go.mod file. |
Is this related to #25556? It seems like in both cases you expect replacements to be applied from converted lock or vendor files. |
Yeah, same cause. The conversion process can only influence the require directive, nothing else. |
Duplicate of #25556. |
go version go1.10 linux/amd64 vgo:2018-02-20.1
Log
this is against the latest Prometheus master.
This info should be enough to reproduce , but let me know if you need anything else.
it seems some awkward case with "origin" and "path"
The text was updated successfully, but these errors were encountered: