Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go get github.com/rsc/vgotest5 fails [1.9 backport] #25691

Closed
gopherbot opened this issue Jun 1, 2018 · 2 comments
Closed

cmd/go: go get github.com/rsc/vgotest5 fails [1.9 backport] #25691

gopherbot opened this issue Jun 1, 2018 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.9.7

Comments

@gopherbot
Copy link

@rsc requested issue #25687 to be considered for backport to the next 1.9 minor release.

@gopherbot PLEASE backport Go 1.9 Go 1.10
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 1, 2018
@gopherbot gopherbot mentioned this issue Jun 1, 2018
Closed
@gopherbot gopherbot added this to the Go1.9.7 milestone Jun 1, 2018
@gopherbot
Copy link
Author

Change https://golang.org/cl/116175 mentions this issue: [release-branch.go1.9] cmd/go: fix 'go get' compatibility for direct download of vgo-aware module

@gopherbot
Copy link
Author

Closed by merging 91f0e20 to release-branch.go1.9.

gopherbot pushed a commit that referenced this issue Jun 4, 2018
@rsc
[release-branch.go1.9] cmd/go: fix 'go get' compatibility for direct …
91f0e20 
…download of vgo-aware module

CL 109340 added “minimal module-awareness for legacy operation.”
One part of that is reinterpreting imports inside code trees with go.mod files
as using semantic import versioning, and converting them back to
legacy import paths by stripping the major version element
(for example, interpreting import "x.com/foo/v2/bar" as import "x.com/foo/bar").
This rewrite was not being applied during "go get", with the effect that once
you had the target code downloaded already, everything was fine,
but it didn't download and build successfully the first time.

Fixes #25687.
Cherry-pick fixes #25691.

Change-Id: I3e122efdc8fd9a0a4e66f5aa3e6a99f90c7df779
Reviewed-on: https://go-review.googlesource.com/115797
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-on: https://go-review.googlesource.com/116175
@golang golang locked and limited conversation to collaborators Jun 4, 2019
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.9.7
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot