Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove Perl script errchk #25669

Closed
ysmolski opened this issue May 31, 2018 · 5 comments
Closed

test: remove Perl script errchk #25669

ysmolski opened this issue May 31, 2018 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@ysmolski
Copy link
Member

No test uses the perl script errchk anymore. We can remove it from the source tree. Is there any other place from which we should remove Perl as well?

@ysmolski ysmolski added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 31, 2018
@ianlancetaylor
Copy link
Contributor

@ysmolsky You marked this as NeedsDecision but I'm not sure what decision you are looking for.

@ianlancetaylor ianlancetaylor added this to the Unplanned milestone May 31, 2018
@josharian
Copy link
Contributor

If no one in the tree uses errchk, it should be deleted. If it turns out that someone else (some x repo?) uses it, they can just make a copy for themselves.

I'm not aware of anywhere else in the tree that uses perl. You could confirm that by removing perl from your PATH and running all.bash.

@josharian josharian added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 1, 2018
@gopherbot gopherbot removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jun 1, 2018
@bradfitz
Copy link
Contributor

bradfitz commented Jun 1, 2018

I'm not aware of anywhere else in the tree that uses perl. You could confirm that by removing perl from your PATH and running all.bash.

Better to make a Docker image with a fake perl in $PATH that returns an error, because some tests (net/http/cgi?) do a LookPath for Perl and skip if not found.

@gopherbot
Copy link

Change https://golang.org/cl/115955 mentions this issue: test: remove errchk, the perl script

@ysmolski
Copy link
Member Author

ysmolski commented Jun 2, 2018

Perl is still being used in these:

src/net/http/cgi/testdata/test.cgi
src/regexp/syntax/make_perl_groups.pl
src/net/http/cgi/host_test.go
src/syscall/*.pl

I will stop here with Perl evictions, if anyone feels up to it, please go ahead with test.cgi and host_test.go.

@ysmolski ysmolski modified the milestones: Unplanned, Go1.12 Jun 7, 2018
@golang golang locked and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

5 participants