Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: actually run the test/safe test #25668

Closed
ysmolski opened this issue May 31, 2018 · 6 comments
Closed

test: actually run the test/safe test #25668

ysmolski opened this issue May 31, 2018 · 6 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.12

Comments

@ysmolski
Copy link
Member

While working on cleaning errchk from go/test/ I have found a directory safe/...: https://github.com/golang/go/tree/master/test/safe

These tests are not being used anymore and they are related to old pre-go gc, checking some internal state.

Can somebody with expertise look at that and decide if we should remove it or keep it and include into testing suite?

@ianlancetaylor
@ysmolski ysmolski added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 31, 2018
@ianlancetaylor
Copy link
Contributor

This is a test of the compiler's -u option. I guess ideally we would preserve this test and actually start running it. The test does pass today (that is, the compilation fails with the expected error).

@ianlancetaylor ianlancetaylor added this to the Unplanned milestone May 31, 2018
@ianlancetaylor ianlancetaylor added NeedsFix The path to resolution is known, but the work has not been done. help wanted labels May 31, 2018
@gopherbot gopherbot removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 31, 2018
@ianlancetaylor ianlancetaylor changed the title test: should we remove unused test/safe/... files? test: actually run the test/safe test May 31, 2018
@gopherbot
Copy link

Change https://golang.org/cl/115935 mentions this issue: test: run tests for unsafe again

@travisby
Copy link

travisby commented Jun 2, 2018 •
edited

I took a stab at this to get familiar with comitting to go :).

This ends up moving some files and copying another; should I use a new Copyright header (with 2018) since they're technically new files in git's eyes, or should I keep the old ones since in spirit it's the same code? I opted for the latter for now, but will be happy to change it.

@ianlancetaylor
Copy link
Contributor

If you just move a file, keep the copyright header. If you create a new file, even if it is based on an existing file, use a new copyright header.

@ysmolski
Copy link
Member Author

@travisby will you be able to handle this?

@gopherbot
Copy link

Change https://golang.org/cl/124660 mentions this issue: test: restore tests for the reject unsafe code option

@ysmolski ysmolski modified the milestones: Unplanned, Go1.12 Jul 19, 2018
@ysmolski ysmolski self-assigned this Jul 19, 2018
@golang golang locked and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
4 participants
@travisby @ysmolski @ianlancetaylor @gopherbot