Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: TestServer_Rejects_TooSmall test flake #25645

Closed
bradfitz opened this issue May 30, 2018 · 3 comments
Closed

x/net/http2: TestServer_Rejects_TooSmall test flake #25645

bradfitz opened this issue May 30, 2018 · 3 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unplanned

Comments

@bradfitz
Copy link
Contributor 

linux-amd64 at c6295e72bf9536d75d3528ad17bdd49f2856b58d building net at 6fcffe453537651f4aa3d93714bc764543ec5978

ok  	golang.org/x/net/bpf	0.482s
ok  	golang.org/x/net/context	0.135s
ok  	golang.org/x/net/context/ctxhttp	0.146s
?   	golang.org/x/net/dict	[no test files]
ok  	golang.org/x/net/dns/dnsmessage	0.085s
ok  	golang.org/x/net/html	0.167s
ok  	golang.org/x/net/html/atom	0.046s
ok  	golang.org/x/net/html/charset	0.040s
ok  	golang.org/x/net/http/httpguts	0.046s
ok  	golang.org/x/net/http/httpproxy	0.037s
--- FAIL: TestServer_Rejects_TooSmall (0.01s)
	server_test.go:561: got a *http2.HeadersFrame; want *RSTStreamFrame
	server_test.go:235: Framer read log:
		2018-05-30 09:10:04.021264382 Framer 0xc0004e67e0: read SETTINGS len=24, settings: MAX_FRAME_SIZE=1048576, MAX_CONCURRENT_STREAMS=250, MAX_HEADER_LIST_SIZE=1048896, INITIAL_WINDOW_SIZE=1048576
		2018-05-30 09:10:04.021454998 Framer 0xc0004e67e0: read WINDOW_UPDATE len=4 (conn) incr=983041
		2018-05-30 09:10:04.021470353 Framer 0xc0004e67e0: read SETTINGS flags=ACK len=0
		2018-05-30 09:10:04.02349049 Framer 0xc0004e67e0: read HEADERS flags=END_STREAM|END_HEADERS stream=1 len=28
	server_test.go:241: Framer write log:
		2018-05-30 09:10:04.020810306 Framer 0xc0004e67e0: wrote SETTINGS len=0
		2018-05-30 09:10:04.021278064 Framer 0xc0004e67e0: wrote SETTINGS flags=ACK len=0
		2018-05-30 09:10:04.021522082 Framer 0xc0004e67e0: wrote HEADERS flags=END_HEADERS stream=1 len=19
		2018-05-30 09:10:04.022606786 Framer 0xc0004e67e0: wrote DATA flags=END_STREAM stream=1 len=5 data="12345"
FAIL
FAIL	golang.org/x/net/http2	9.339s
?   	golang.org/x/net/http2/h2i	[no test files]
@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. help wanted NeedsFix The path to resolution is known, but the work has not been done. labels May 30, 2018
@bradfitz bradfitz added this to the Unplanned milestone May 30, 2018
@bradfitz bradfitz self-assigned this May 30, 2018
@fraenkel
Copy link
Contributor

@bradfitz I found a simple way to prevent this timing issue. I will go ahead and submit a CL for your review unless you have something in mind.

@fraenkel
Copy link
Contributor

Acutally, nevermind. I realize my fix just covers up an underlying issue.

@gopherbot
Copy link

Change https://golang.org/cl/121197 mentions this issue: http2: Test should wait until RSTStreamFrame appears

@golang golang locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@bradfitz @fraenkel @gopherbot