Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cgo: "DO NOT EDIT" generated code comments do not follow recommendations #25623

Closed
ghost opened this issue May 29, 2018 · 1 comment
Closed

cmd/cgo: "DO NOT EDIT" generated code comments do not follow recommendations #25623

ghost opened this issue May 29, 2018 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.11

Comments

@ghost
Copy link

ghost commented May 29, 2018

cgo currently generates files with header comments in the following forms:

  • /* Created by "go tool cgo" - DO NOT EDIT. */, and
  • // Created by cgo - DO NOT EDIT

These do not following the recommendations made in #13560 (https://golang.org/s/generatedcode).
@ghost ghost changed the title cgo: "DO NOT EDIT" generated code comment does not follow recommendations cgo: "DO NOT EDIT" generated code comments do not follow recommendations May 29, 2018
@ianlancetaylor ianlancetaylor changed the title cgo: "DO NOT EDIT" generated code comments do not follow recommendations cmd/cgo: "DO NOT EDIT" generated code comments do not follow recommendations May 29, 2018
@ianlancetaylor ianlancetaylor added the NeedsFix The path to resolution is known, but the work has not been done. label May 29, 2018
@ianlancetaylor ianlancetaylor added this to the Go1.11 milestone May 29, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/115035 mentions this issue: cmd/cgo: use standard generated code comment

@golang golang locked and limited conversation to collaborators May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
2 participants
@ianlancetaylor @gopherbot