Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/internal/gcimporter: error with embedded non-interface (possibly an incomplete type) #25615

Closed
griesemer opened this issue May 29, 2018 · 4 comments
Closed

go/internal/gcimporter: error with embedded non-interface (possibly an incomplete type) #25615

griesemer opened this issue May 29, 2018 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.11

Comments

@griesemer
Copy link
Contributor

To reproduce:

  1. go get github.com/google/go-cmp/cmp
  2. cd $GOPATH/src/github.com/google/go-cmp/cmp
  3. go test
# github.com/google/go-cmp/cmp_test
./compare_test.go:23:2: could not import github.com/google/go-cmp/cmp (cannot import, possibly version skew (embedded type is not an interface) - reinstall package)
./compare_test.go:481:23: cannot range over p (invalid operand)
vet: typecheck failures
FAIL	github.com/google/go-cmp/cmp [build failed]
@griesemer griesemer added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) labels May 29, 2018
@griesemer griesemer added this to the Go1.11 milestone May 29, 2018
@griesemer griesemer self-assigned this May 29, 2018
@griesemer
Copy link
Contributor Author

Appears to be related to fix for #25301.

@griesemer griesemer mentioned this issue May 29, 2018
Closed
@griesemer
Copy link
Contributor Author

This is probably a duplicate of #25596.

@sbinet sbinet mentioned this issue May 29, 2018
Merged
@gopherbot
Copy link

Change https://golang.org/cl/115155 mentions this issue: go/types: don't over-eagerly verify embedded interfaces

@myitcv
Copy link
Member

myitcv commented May 30, 2018

Thanks very much @griesemer!

@golang golang locked and limited conversation to collaborators May 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
3 participants
@myitcv @griesemer @gopherbot