Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: eliminate use of Perl in test/fixedbugs/... #25586

Closed
ysmolski opened this issue May 26, 2018 · 10 comments
Closed

test: eliminate use of Perl in test/fixedbugs/... #25586

ysmolski opened this issue May 26, 2018 · 10 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.11

Comments

@ysmolski
Copy link
Member

ysmolski commented May 26, 2018 •
edited

In cont. of #20032.
These are the last users of Perl script test/errchk:

https://github.com/golang/go/blob/master/test/fixedbugs/bug248.go
https://github.com/golang/go/blob/master/test/fixedbugs/bug345.go

Converting those tests to Go code will allow to remove errchk script completely.
@ysmolski ysmolski added the NeedsFix The path to resolution is known, but the work has not been done. label May 26, 2018
@gopherbot
Copy link

Change https://golang.org/cl/114818 mentions this issue: test: eliminate use of Perl from test/fixedbugs/bug248.go

@agnivade agnivade added this to the Go1.11 milestone May 26, 2018
@ysmolski
Copy link
Member Author

ysmolski commented May 26, 2018 •
edited

fix of bug345.go most probably depends on #25568, at least it blocked me.

gopherbot pushed a commit that referenced this issue May 26, 2018
@ysmolski @bradfitz
test: eliminate use of Perl in test/fixedbugs/bug248.go
cb80c28 
This change enables bug248 to be tested with Go code.
For that, it adds a flag -1 to error check and run directory
with one package failing compilation prior the last package
which should be run.

Specifically, the "p" package in bug1.go file was renamed into "q"
to compile them in separate steps,
bug2.go and bug3.go files were reordered,
bug2.go was changed into non-main package.

Updates #25586.

Change-Id: Ie47aacd56ebb2ce4eac66c792d1a53e1e30e637c
Reviewed-on: https://go-review.googlesource.com/114818
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/115277 mentions this issue: test: eliminate use of Perl in fixedbugs/bug345.go

@ysmolski
Copy link
Member Author

Bug345 fails on windows: https://build.golang.org/log/f2ce8c84cdd5abbb40225e1dad6245877e5e6006
Not sure why trybots didnt catch it.

Reopened.

@ysmolski ysmolski reopened this May 31, 2018
@ysmolski
Copy link
Member Author

@ALTree can you help with fixing this test for windows?

@ALTree
Copy link
Member

ALTree commented May 31, 2018

I don't use windows, sorry. I see that of the 4 windows builders only 2 are failing... so maybe it has something to do with the builders environment? Maybe @alexbrainman can help.

@ysmolski
Copy link
Member Author

ysmolski commented Jun 1, 2018

It does not fail on builders which does not run tests in test/...: ShouldRunDistTest: noTestDir, meaning that it fails on all Windows builds running this test.

@ysmolski
Copy link
Member Author

ysmolski commented Jun 1, 2018

Created a follow up: #25693

@bradfitz
Copy link
Contributor

bradfitz commented Jun 1, 2018

Not sure why trybots didnt catch it.

Trybots are a fast subset of build configs that aim to be as broad as possible. Some things slip through.

@gopherbot
Copy link

Change https://golang.org/cl/115857 mentions this issue: test: skip test/fixedbugs/bug345.go on windows

@golang golang locked and limited conversation to collaborators Jun 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
5 participants
@bradfitz @ysmolski @agnivade @ALTree @gopherbot