Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strings: Map produces invalid utf-8 when passed PAD (U+0080) [1.9 backport] #25573

Closed
andybons opened this issue May 25, 2018 · 2 comments
Closed

strings: Map produces invalid utf-8 when passed PAD (U+0080) [1.9 backport] #25573

andybons opened this issue May 25, 2018 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.9.7

Comments

@andybons
Copy link
Member

Backport tracking bug for #25242

https://golang.org/cl/111286
@andybons andybons added NeedsFix The path to resolution is known, but the work has not been done. CherryPickApproved Used during the release process for point releases labels May 25, 2018
@andybons andybons added this to the Go1.9.7 milestone May 25, 2018
@gopherbot
Copy link

Change https://golang.org/cl/114636 mentions this issue: [release-branch.go1.9] strings: fix encoding of \u0080 in map

@gopherbot
Copy link

Closed by merging 408b3d7 to release-branch.go1.9.

gopherbot pushed a commit that referenced this issue May 26, 2018
@martisch @andybons
[release-branch.go1.9] strings: fix encoding of \u0080 in map
408b3d7 
Fix encoding of PAD (U+0080) which has the same value as utf8.RuneSelf
being incorrectly encoded as \x80 in strings.Map due to using <= instead
of a < comparison operator to check one byte encodings for utf8.

Fixes #25573

Change-Id: Ib6c7d1f425a7ba81e431b6d64009e713d94ea3bc
Reviewed-on: https://go-review.googlesource.com/111286
Run-TryBot: Martin Möhrmann <moehrmann@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 8c62fc0)
Reviewed-on: https://go-review.googlesource.com/114636
Run-TryBot: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@golang golang locked and limited conversation to collaborators May 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.9.7
Development

No branches or pull requests
2 participants
@andybons @gopherbot