New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/vgo: Hangs if SSH ControlPersist is set #25567
Labels
Milestone
Comments
pwaller
changed the title
x/vgo: Hangs if ControlPersist is set
x/vgo: Hangs if SSH ControlPersist is set
May 25, 2018
I take it back, I'm still hitting this even after golang/vgo@c4312af. Here's a SIGQUIT sent whilst it was hung during a go install: Click to expand SIGQUIT stacktrace
|
Change https://golang.org/cl/116757 mentions this issue: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reproduced with Go 1.10 and golang/vgo@b85f725.
As with #13453 which was fixed in e6a901e, vgo will hang indefinitely if
ControlMaster
is set and git is configured to always use SSH transport withurl.*.insteadOf
.Somewhere in the bowels of my
.ssh/config
:And in my git config, I have the following, which makes it always use SSH (so that I may import private repositories):
The effect is that vgo hangs when doing various operations. I've witnessed it hanging doing a
vgo install
and avgo list -t
.I believe a valid fix would be to do what is done in e6a901e. I've tested that locally if I set
GIT_SSH_COMMAND
to include-o ControlPersist=no
incodehost/codehost.go:Run()
, then it works as expected.The text was updated successfully, but these errors were encountered: