New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/vgo: disable git password prompts #25544
Comments
It can do multiple git commands per repo, sorry. I don't think it's an infinite loop, just very annoying. Regular "go get" disables git prompting for passwords entirely. Probably vgo should do the same. |
vgo build
on package
I thought so too when I first looked at it and kept entering the SSH password, but after looking at the strace, it seems like it's not really doing anything but waiting on a futex and asking for the password again. |
Change https://golang.org/cl/114522 mentions this issue: |
@t94j0: Out of interest, how are you running strace? If you don't run with |
@pwaller I didn't run with the It makes sense now. Thanks! |
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version
)?go version go1.10.2 linux/amd64
go version go1.10.2 linux/amd64 vgo:2018-02-20.1
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?Manjaro Linux
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/user/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/user/Programming/go"
GORACE=""
GOROOT="/usr/lib/go"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build576044457=/tmp/go-build -gno-record-gcc-switches"
What did you do?
The company I am working for has a GitLab server hosting our Go packages. We all connect to the git server with SSH keys. Co-workers and I used
vgo build .
.This should be reproducable if you have a private GitHub repository, SSH keys attached to your account (https://github.com/settings/keys) with passwords on them and do a
vgo get github.com/USER/PRIVATE_REPO
.What did you expect to see?
What did you see instead?
An infinite loop of asking
Enter passphrase for key '/home/user/.ssh/id_rsa':
. This is a normal message when doinggit clone gitlab.server.local/user/repo
, but only once. You would imagine vgo would ask for the SSH keys recursively for every local Go package which is a requirement of the/user/repo
package, but when doing an strace, it shows that nothing is really happening:This is returned infinitely.
The text was updated successfully, but these errors were encountered: