Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix: failing tests on android and iOS #25535

Closed
tklauser opened this issue May 24, 2018 · 8 comments
Closed

x/sys/unix: failing tests on android and iOS #25535

tklauser opened this issue May 24, 2018 · 8 comments
Labels
FrozenDueToAge OS-Android
Milestone
Unreleased

Comments

@tklauser
Copy link
Member

tklauser commented May 24, 2018 •
edited

The tests in the vendored copy of golang.org/x/sys/unix (through https://golang.org/cl/112436) fail on android and iOS.

android:

https://build.golang.org/log/ad205265eb82b05e15ce4484f31ead3d7882ed02

--- FAIL: TestPpoll (0.00s)
	syscall_unix_test.go:567: mktmpfifo: failed to create FIFO: permission denied
--- FAIL: TestPoll (0.00s)
	syscall_unix_test.go:567: mktmpfifo: failed to create FIFO: permission denied
--- FAIL: TestGetwd (0.00s)
	syscall_unix_test.go:447: Chdir: chdir /usr/bin: no such file or directory
--- FAIL: TestFchmodat (0.00s)
	syscall_unix_test.go:541: Fchmodat: unexpected error: operation not supported

iOS, added after #25535 (comment):

https://build.golang.org/log/3503d3c0543b005b00f6d7dc2f5ff9844376ceea

--- FAIL: TestDevices (0.00s)
    --- FAIL: TestDevices//dev/ttyp0_4:0 (0.00s)
    	dev_darwin_test.go:35: failed to stat device: operation not permitted
    --- FAIL: TestDevices//dev/ttys0_4:48 (0.00s)
    	dev_darwin_test.go:35: failed to stat device: no such file or directory
    --- FAIL: TestDevices//dev/ptyp0_5:0 (0.00s)
    	dev_darwin_test.go:35: failed to stat device: operation not permitted
    --- FAIL: TestDevices//dev/ptyr0_5:32 (0.00s)
    	dev_darwin_test.go:35: failed to stat device: no such file or directory
--- FAIL: TestPassFD (0.00s)
	syscall_unix_test.go:159: child process: "", fork/exec /var/containers/Bundle/Application/24E1B73D-9932-4B0A-ADAD-44DE6672CC02/gotest.app/gotest: operation not permitted
--- FAIL: TestPoll (0.00s)
	syscall_unix_test.go:567: mktmpfifo: failed to create FIFO: operation not permitted

/cc @hyangah
@gopherbot gopherbot added this to the Unreleased milestone May 24, 2018
@gopherbot
Copy link

Change https://golang.org/cl/114395 mentions this issue: unix: fix or skip failing tests on android

@tklauser
Copy link
Member Author

On android/{arm,arm64}, also TestDevices and TestSchedSetaffinity fail in addition to the already mentioned tests:

https://build.golang.org/log/064fd97a14c0995ace8d4e2cc978a8b0814ddea0

--- FAIL: TestDevices (0.00s)
    --- FAIL: TestDevices//dev/full_1:7 (0.00s)
    	dev_linux_test.go:36: failed to stat device: permission denied
--- FAIL: TestPpoll (0.00s)
	syscall_unix_test.go:567: mktmpfifo: failed to create FIFO: permission denied
--- FAIL: TestSchedSetaffinity (0.00s)
	syscall_linux_test.go:265: SchedSetaffinity: invalid argument
--- FAIL: TestPoll (0.00s)
	syscall_unix_test.go:567: mktmpfifo: failed to create FIFO: permission denied
--- FAIL: TestGetwd (0.00s)
	syscall_unix_test.go:447: Chdir: chdir /usr/bin: no such file or directory
--- FAIL: TestFchmodat (0.00s)
	syscall_unix_test.go:541: Fchmodat: unexpected error: operation not supported

@tklauser
Copy link
Member Author

/cc @eliasnaur

@eliasnaur
Copy link
Contributor

Some tests fail on iOS as well:

https://build.golang.org/log/3503d3c0543b005b00f6d7dc2f5ff9844376ceea

@tklauser
Copy link
Member Author

Thanks. The TestDevices failures should be gone with https://golang.org/cl/114396. I'll send a fix for the others.

@tklauser tklauser changed the title x/sys/unix: failing tests on android x/sys/unix: failing tests on android and iOS May 24, 2018
@gopherbot
Copy link

Change https://golang.org/cl/114396 mentions this issue: unix: delete TestDevices for *BSD and Darwin

@gopherbot
Copy link

Change https://golang.org/cl/114415 mentions this issue: ssh/terminal: fix TestMakeRawState on iOS

gopherbot pushed a commit to golang/sys that referenced this issue May 24, 2018
@tklauser
unix: delete TestDevices for *BSD and Darwin
e2c7578 
Instead, add a small test verify Major, Minor and Mkdev using arbitrary
numbers.

Leave TestDevices on Linux as its major/minor numbers are guaranteed
stable.

Updates golang/go#25528
Updates golang/go#25535

Change-Id: Ic105211660d80f9b3508ca9d518e9fac3b7e3beb
Reviewed-on: https://go-review.googlesource.com/114396
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
gopherbot pushed a commit to golang/crypto that referenced this issue May 24, 2018
@tklauser
ssh/terminal: fix TestMakeRawState on iOS
159ae71 
Fix the following failure on iOS:

--- FAIL: TestMakeRawState (0.00s)
	terminal_test.go:332: failed to get terminal state from MakeRaw: operation not permitted

Updates golang/go#25535

Change-Id: I1ab6feb31ba5e89dc0d5f2a1cefd56c09f178e80
Reviewed-on: https://go-review.googlesource.com/114415
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/114416 mentions this issue: cmd/vendor/golang/x: pick up upstream fixes for broken android and iOS tests

gopherbot pushed a commit that referenced this issue May 24, 2018
@tklauser
cmd/vendor/golang.org/x: pick up upstream fixes for broken android an…
c2b4b31 
…d iOS tests

Pick up the changes from CL 114395, CL 114396 and CL 114415.

By re-running govendor in the latest version, some files from
golang.org/x/sys/unix which are ignored for the build also got removed
from the vendored copy.

Updates #25528
Updates #25535

Change-Id: I5c0002fc3a37d6abaafed2e15cc3e2ade803ad7b
Reviewed-on: https://go-review.googlesource.com/114416
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators May 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Android
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@eliasnaur @tklauser @gopherbot