New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/vgo: internal tests failing #25501
Comments
I made vgotest1 no longer private today (oops). The ConvertLegacyConfig failure still needs to be investigated. |
Change https://golang.org/cl/116836 mentions this issue: |
Change https://golang.org/cl/116615 mentions this issue: |
Change https://golang.org/cl/117035 mentions this issue: |
Change https://golang.org/cl/117115 mentions this issue: |
Change https://golang.org/cl/117235 mentions this issue: |
I suspect an HTTP server is now guarding test requests:
The call to |
Ah, I figured out where I went wrong above. The specific GET didn't have a recorded response. Adding it with -webtest "record" fixed it. |
…ConvertLegacyConfig Support for major-version parsing for gopkg.in dependencies was improved in CL 107658, but TestConvertLegacyConfig was apparently not updated to reflect that. Updates golang/go#25501. Before: --- FAIL: TestConvertLegacyConfig (32.51s) --- FAIL: TestConvertLegacyConfig/github.com_docker_distribution_v0.0.0-20150410205453-85de3967aa93 (0.00s) convert_test.go:102: golden:23: invalid module: gopkg.in/yaml.v2 should be v2, not v0 (v0.0.0-20150116202057-bef53efd0c76) After: --- PASS: TestConvertLegacyConfig (40.00s) --- PASS: TestConvertLegacyConfig/github.com_docker_distribution_v0.0.0-20150410205453-85de3967aa93 (40.00s) Change-Id: Ied0121e78b43355f6349684f1e1836da9e587374 Reviewed-on: https://go-review.googlesource.com/117115 Reviewed-by: Russ Cox <rsc@golang.org>
"vgo build" caches to $GOPATH, which defaults to $HOME/go. Therefore, tests of a "build" command must set at least one of {$GOPATH, $HOME}. Updates golang/go#25501. Change-Id: I798a0b180c3d8c4850e9a54e303bbcef1bab5faf Reviewed-on: https://go-review.googlesource.com/117235 Reviewed-by: Russ Cox <rsc@golang.org>
Change https://golang.org/cl/118415 mentions this issue: |
This test appears to have been broken by https://golang.org/cl/104975. Updates golang/go#24694. Updates golang/go#25501. Before: ~/src/golang.org/x/vgo/vendor/cmd/go$ go test -run=TestExecutableGOROOT . --- FAIL: TestExecutableGOROOT (0.15s) --- FAIL: TestExecutableGOROOT/RuntimeGoroot (0.00s) go_test.go:4598: /tmp/gotest104327550/new/bin/go run testdata/print_goroot.go: exit status 1, vgo requires Go 1.10 but VGOROOT=/tmp/gotest104327550/new is not a Go 1.10 source tree FAIL FAIL golang.org/x/vgo/vendor/cmd/go 1.730s After: ~/src/golang.org/x/vgo/vendor/cmd/go$ go test -run=TestExecutableGOROOT . ok golang.org/x/vgo/vendor/cmd/go 2.870s Change-Id: I155a1344ec704c53d3678390cafc1ad33d1a338b Reviewed-on: https://go-review.googlesource.com/116615 Reviewed-by: Russ Cox <rsc@golang.org>
It seems to have been broken by CL 104975: we were invoking `vgo env` with a GOROOT that did not have a complete source tree. Updates golang/go#25501. Change-Id: I238f710bc094cbae9381e3fdd49d5c1f999b5ea5 Reviewed-on: https://go-review.googlesource.com/117035 Reviewed-by: Russ Cox <rsc@golang.org>
Change https://golang.org/cl/118718 mentions this issue: |
Replacement for CL 116836. For golang/go#25501. Change-Id: Ie4f15dc11d9499aeeb497b7aceff2efd2bcd7ce3 Reviewed-on: https://go-review.googlesource.com/118718 Reviewed-by: Daniel Theophanes <kardianos@gmail.com> Reviewed-by: Bryan C. Mills <bcmills@google.com>
Apparently I need to learn to trust Gerrit less. It showed the correct diff, I pressed Submit, and when I went to rebase the change was in the wrong place. Updates golang/go#25501. Change-Id: I85dfc9b57090bdd8ac888e705175c5397938405e Reviewed-on: https://go-review.googlesource.com/118415 Reviewed-by: Russ Cox <rsc@golang.org>
Change https://golang.org/cl/119015 mentions this issue: |
Updates golang/go#25501. Current failure mode: --- FAIL: TestNewReleaseRebuildsStalePackagesInGOPATH (3.38s) go_test.go:910: running testgo [install -i p1] go_test.go:911: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1] go_test.go:911: standard output: go_test.go:911: false: go_test.go:920: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1] go_test.go:920: standard output: go_test.go:920: false: go_test.go:927: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1] go_test.go:927: standard output: go_test.go:927: false: go_test.go:927: ./testgo list claims p1 is NOT stale, incorrectly, after changing sys.go Change-Id: I58b78b7e9b3ddf16e0f7949fc33dba89aa3d5b93 Reviewed-on: https://go-review.googlesource.com/119015 Reviewed-by: Russ Cox <rsc@golang.org>
Change https://golang.org/cl/119075 mentions this issue: |
Change https://golang.org/cl/119076 mentions this issue: |
As of CL 119076, |
After this change and CL 119075, "go test ./..." from the vendor directory succeeds. Updates golang/go#25501. Change-Id: Ife1904ea162b4108ff45db2f0c87079e803b1e99 Reviewed-on: https://go-review.googlesource.com/119076 Reviewed-by: Russ Cox <rsc@golang.org>
Updates golang/go#25501. Before: --- FAIL: TestCodeRepo (20.13s) --- FAIL: TestCodeRepo/github.com_rsc_vgotest1_v2/v2.0.0 (0.47s) coderepo_test.go:424: repo.Zip("v2.0.0"): missing or invalid go.mod, want error "missing go.mod" --- FAIL: TestCodeRepo/github.com_rsc_vgotest1_v2/80d85 (0.34s) coderepo_test.go:409: repo.GoMod("v2.0.0-20180219231006-80d85c5d4d17"): missing or invalid go.mod, want "missing go.mod" coderepo_test.go:424: repo.Zip("v2.0.0-20180219231006-80d85c5d4d17"): missing or invalid go.mod, want error "missing go.mod" --- FAIL: TestCodeRepo/github.com_rsc_vgotest1_v54321/80d85 (0.28s) coderepo_test.go:424: repo.Zip("v54321.0.0-20180219231006-80d85c5d4d17"): missing or invalid go.mod, want error "missing go.mod" vgo: lookup code.google.com/p/go-uuid/uuid: unknown module code.google.com/p/go-uuid/uuid: no go-import tags After: ok golang.org/x/vgo/vendor/cmd/go/internal/modfetch 123.433s Change-Id: I1263af1104b36b519ab9e79c74bb8c2eed05797e Reviewed-on: https://go-review.googlesource.com/119075 Reviewed-by: Daniel Theophanes <kardianos@gmail.com>
I think this is fixed. |
Right now at rev b39cea3cb5353f4fc7f08919d32a0006ea3ed62a in the vgo repo some of the tests are failing:
We should fix this before integrating with the main repo.
The text was updated successfully, but these errors were encountered: