Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/build: call ctxt.match for checking file name constraints #25480

Closed
wants to merge 2 commits into from

Conversation

linzhp
Copy link
Contributor

@linzhp linzhp commented May 21, 2018

This makes the checking of build tags in file names consistent to that of the build tags in // +build line.

Fixed #25461

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label May 21, 2018
@gopherbot
Copy link

This PR (HEAD: e45ff5b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/113818 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 1:

(1 comment)

Is there a new test that can be added somewhere?


Please don’t reply on this GitHub thread. Visit golang.org/cl/113818.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Zhongpeng Lin:

Patch Set 1:

Patch Set 1:

(1 comment)

Is there a new test that can be added somewhere?

Coming soon...


Please don’t reply on this GitHub thread. Visit golang.org/cl/113818.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 11b14e2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/113818 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@linzhp
Copy link
Contributor Author

linzhp commented May 21, 2018

OK. Test added as promised. Please take another look

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 2: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/113818.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=d75f0615


Please don’t reply on this GitHub thread. Visit golang.org/cl/113818.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/113818.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request May 22, 2018
This makes the checking of build tags in file names consistent to that of the build tags in `// +build` line.

Fixed #25461

Change-Id: Iba14d1050f8aba44e7539ab3b8711af1980ccfe4
GitHub-Last-Rev: 11b14e2
GitHub-Pull-Request: #25480
Reviewed-on: https://go-review.googlesource.com/113818
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 2: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/113818.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR is being closed because golang.org/cl/113818 has been merged.

@gopherbot gopherbot closed this May 22, 2018
@linzhp linzhp deleted the build_tags branch May 25, 2018 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants