Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strings: Map produces invalid utf-8 when passed PAD (U+0080) [1.10 backport] #25479

Closed
gopherbot opened this issue May 21, 2018 · 3 comments
Closed

strings: Map produces invalid utf-8 when passed PAD (U+0080) [1.10 backport] #25479

gopherbot opened this issue May 21, 2018 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.10.3

Comments

@gopherbot
Copy link

@anupcshan requested issue #25242 to be considered for backport to the next 1.10 minor release.

@gopherbot Please consider this for backport to 1.10, it's a regression.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 21, 2018
@gopherbot gopherbot mentioned this issue May 21, 2018
Closed
@gopherbot gopherbot added this to the Go1.10.3 milestone May 21, 2018
@msolo-dropbox
Copy link

This does seem worthy of backport. It looks like the whole 1.9 branch also has this issue which means that anyone on 1.8 or before has to skip two full release cycles, or start maintaining a fork.

What is the likelihood this will be included in 1.10.3?

@rsc
Copy link
Contributor

rsc commented May 25, 2018

@msolo-dropbox, seems likely to me, since the fix was committed on master and this issue exists.
@andybons, can this be backported to Go 1.9 too please?

@andybons andybons added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels May 25, 2018
@gopherbot
Copy link
Author

Change https://golang.org/cl/114635 mentions this issue: [release-branch.go1.10] strings: fix encoding of \u0080 in map

gopherbot pushed a commit that referenced this issue May 26, 2018
@martisch @andybons
[release-branch.go1.10] strings: fix encoding of \u0080 in map
2bded9d 
Fix encoding of PAD (U+0080) which has the same value as utf8.RuneSelf
being incorrectly encoded as \x80 in strings.Map due to using <= instead
of a < comparison operator to check one byte encodings for utf8.

Fixes #25479

Change-Id: Ib6c7d1f425a7ba81e431b6d64009e713d94ea3bc
Reviewed-on: https://go-review.googlesource.com/111286
Run-TryBot: Martin Möhrmann <moehrmann@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 8c62fc0)
Reviewed-on: https://go-review.googlesource.com/114635
Run-TryBot: Andrew Bonventre <andybons@golang.org>
@golang golang locked and limited conversation to collaborators May 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.10.3
Development

No branches or pull requests
4 participants
@rsc @andybons @gopherbot @msolo-dropbox