Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/pprof: links to pprof documentation outdated #25477

Closed
tumdum opened this issue May 21, 2018 · 6 comments
Closed

runtime/pprof: links to pprof documentation outdated #25477

tumdum opened this issue May 21, 2018 · 6 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@tumdum
Copy link

tumdum commented May 21, 2018

What version of Go are you using (go version)?

go version go1.10 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOCACHE="/home/tumdum/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/tumdum/go"
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build079040877=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Clicked link https://github.com/google/pprof/blob/master/doc/pprof.md on https://golang.org/pkg/runtime/pprof/

What did you expect to see?

Documentation of pprof.

What did you see instead?

Empty page (404).

Most likely the correct link should now be https://github.com/google/pprof/blob/master/doc/README.md

@ALTree
Copy link
Member

ALTree commented May 21, 2018

@tumdum want to send a patch?

@ALTree ALTree added the NeedsFix The path to resolution is known, but the work has not been done. label May 21, 2018
@tumdum
Copy link
Author

tumdum commented May 21, 2018

@ALTree I would like to, but I never built go from source and I don't have anything setup out of stuff described in Contribution Guide - it will most likely take me few days to set it all up.

@ALTree
Copy link
Member

ALTree commented May 21, 2018

No problem, I'll do it.

@gopherbot
Copy link

Change https://golang.org/cl/113839 mentions this issue: runtime/pprof: update stale link in documentation

@ALTree ALTree added this to the Go1.11 milestone May 21, 2018
@gopherbot
Copy link

Change https://golang.org/cl/119321 mentions this issue: Update more stale pprof links

@gopherbot
Copy link

Change https://golang.org/cl/119321 mentions this issue: doc: update more stale pprof links

gopherbot pushed a commit that referenced this issue Jun 17, 2018
Related to #25477.

Change-Id: I11261c6055b446ceca1b3acc538ab00fec4b47ca
Reviewed-on: https://go-review.googlesource.com/119321
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Jun 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants