Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground: in About text, document that vet is used #25462

Closed
meirf opened this issue May 19, 2018 · 3 comments
Closed

x/playground: in About text, document that vet is used #25462

meirf opened this issue May 19, 2018 · 3 comments
Labels
Documentation FrozenDueToAge
Milestone
Unreleased

Comments

@meirf
Copy link
Contributor

meirf commented May 19, 2018

Now that vet is included in playground Run, the About text should mention it.

Current:

The service receives a Go program, compiles, links, and runs the program inside a sandbox, then returns the output.

Maybe something like "... receives a Go program, compiles, links, vets and runs the program inside a sandbox..."

@ysmolsky

One counterargument is that "go vet" is a pretty unique search query and goes straight to https://golang.org/cmd/vet anyway.
@gopherbot gopherbot added this to the Unreleased milestone May 19, 2018
@meirf meirf changed the title x/playground: document that vet is used in About text x/playground: in About text, document that vet is used May 19, 2018
@ysmolski
Copy link
Member

ysmolski commented Oct 8, 2018

I think we should do this. Preparing the patch.

@gopherbot
Copy link

Change https://golang.org/cl/140497 mentions this issue: playground: mention vet in about text

@dmitshur
Copy link
Contributor

dmitshur commented Oct 8, 2018

I've deployed the new version. Thanks @ysmolsky!

@dmitshur dmitshur mentioned this issue Oct 8, 2018
Closed
matfax pushed a commit to gofunky/playground that referenced this issue Oct 9, 2018
@ysmolski @matfax
playground: mention vet in about text
05abbdf 
Fixes golang/go#25462

Change-Id: I11b861352b53f9492cd1f5c6d8c434edd68e4bd9
Reviewed-on: https://go-review.googlesource.com/c/140497
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@golang golang locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@ysmolski @dmitshur @meirf @gopherbot