Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/playground: running this program does not display output #25455

Closed
ysmolski opened this issue May 18, 2018 · 4 comments
Closed

x/playground: running this program does not display output #25455

ysmolski opened this issue May 18, 2018 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@ysmolski
Copy link
Member

ysmolski commented May 18, 2018

After introducing the "vet" tool into playground the program below does not work. It holds forever with the message: Waiting for remote server...

package main

import (
	"fmt"
)

func main() {
	return
	fmt.Println("Hello, playground\n")
}

Both of endpoints (/compile and /vet) return responses. The problem lies in the JS code.

@ysmolski ysmolski added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 18, 2018
@gopherbot gopherbot added this to the Unreleased milestone May 18, 2018
@ysmolski ysmolski self-assigned this May 18, 2018
@gopherbot
Copy link

Change https://golang.org/cl/113875 mentions this issue: playground.js: display vet errors when program has no output

@ysmolski ysmolski added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 20, 2018
@ysmolski
Copy link
Member Author

PTAL @andybons

@andybons
Copy link
Member

@ysmolsky I would ping me on the review itself, not the issue.

@ysmolski
Copy link
Member Author

Right on, next time I will do that.
It's just from my experience that pings on reviews work worse :-)

@golang golang locked and limited conversation to collaborators May 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants