CC @andybons

SGTM. But we don't record any GitHub commit activity in maintner, so the bot wouldn't know what it has or hasn't already done. But I suppose it could do occasional background queries of the past few dozen commits and lock any that aren't locked, and not use maintner at all.

/cc @dmitshur

I've looked into this.

I think a better place to implement this might be in x/build/cmd/gitmirror, the command responsible for mirroring the canonical git repositories from go.googlesource.com to github.com/golang. In addition to pushing the commits, gitmirror can immediately lock conversation on the newly pushed commit.

According to https://help.github.com/articles/locking-conversations/, it's possible to:

lock conversations on issues, pull requests, and commits permanently or temporarily

I've looked into GitHub API v3 and I found existing endpoints to lock conversation on issues (https://developer.github.com/v3/issues/#lock-an-issue). I don't see a dedicated method for locking conversation on PRs, but I would guess the same endpoint might work on PRs because PRs are treated like issues in many ways.

However, I don't see an endpoint for locking conversation on commits at https://developer.github.com/v3/repos/commits/. It's possible it exists, but like for PRs, doesn't have documentation coverage.

I've also looked into GitHub API v4 and it contains a pretty generic lockLockable mutation that takes a lockableId input field. It's documented as "ID of the issue or pull request to be locked", so it may or may not support commits either. Edit: The Lockable interface is very clear in that it's implemented by Issue and PullRequest only.

So, the next step is to check if GitHub has API support for locking commits programmatically (and request it if not).

Edit: I've created https://platform.github.community/t/api-to-lock-conversations-on-commits/6891 to request this for GitHub GraphQL API v4.

Change https://golang.org/cl/284713 mentions this issue: commitcommentshook: politely respond to commit comments on golang/go