Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/devapp: show GitHub usernames for CLs from PRs #25447

Closed
bradfitz opened this issue May 17, 2018 · 2 comments
Closed

x/build/devapp: show GitHub usernames for CLs from PRs #25447

bradfitz opened this issue May 17, 2018 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

Gerritbot brings in PRs to Gerrit with the author "Gerrit Bot", and this makes its way to the dev dashboard:

https://dev.golang.org/reviews?owner=Gerrit%20Bot

We should show GitHub usernames there instead.

/cc @andybons @bcmills @FiloSottile
@gopherbot gopherbot added this to the Unreleased milestone May 17, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 17, 2018
@dmitshur
Copy link
Contributor

dmitshur commented Aug 4, 2018 •
edited

We also have issue #23964, which is the root problem. When/if that is resolved, this issue will be obsolete.

If that issue is lot of work and takes a long while, while this one is quick and easy, it might be worth it to solve it with a // TODO: Remove when golang.org/issue/23964 is resolved. comment.

@dmitshur
Copy link
Contributor

This is an old bug that happens to be resolved by now. PRs still have "GerritBot" as the CL uploader, but the CL author field is being set correctly, so https://dev.golang.org/reviews shows people's names for PRs. Closing.

@golang golang locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @dmitshur @gopherbot