cmd/compile: 'unexpected source op' spam in GOSSAFUNC output #25404
Labels
Milestone
Comments
|
@heschik |
|
Change https://golang.org/cl/113275 mentions this issue: |
|
Thanks. There are three issues here:
Most of the unexpected() calls have gone by the wayside in refactoring passes, so I could probably just convert these to log statements now. |
gopherbot
pushed a commit
that referenced
this issue
May 15, 2018
Before: unexpected at 2721:load with unexpected source op v3278unexpected at 2775:load with unexpected source op v3281unexpected at 2249:load with unexpected source op v3289unexpected at 2875:load with unexpected source op v3278unexpected at 2232:load with unexpected source op v286unexpected at 2231:load with unexpected source op v3291unexpected at 2784:load with unexpected source op v3289unexpected at 2785:load with unexpected source op v3291 After: debug info generation: v2721: load with unexpected source op: Phi (v3278) debug info generation: v2775: load with unexpected source op: Phi (v3281) debug info generation: v2249: load with unexpected source op: Phi (v3289) debug info generation: v2875: load with unexpected source op: Phi (v3278) debug info generation: v2232: load with unexpected source op: Phi (v286) debug info generation: v2231: load with unexpected source op: Phi (v3291) debug info generation: v2784: load with unexpected source op: Phi (v3289) debug info generation: v2785: load with unexpected source op: Phi (v3291) Updates #25404. Change-Id: Ib97722848d27ca18bdcd482a610626bc3c6def7d Reviewed-on: https://go-review.googlesource.com/113275 Run-TryBot: Michael Munday <mike.munday@ibm.com> Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
|
Change https://golang.org/cl/114008 mentions this issue: |
|
Change https://golang.org/cl/114007 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
May 23, 2018
Remove the unexpected function, which is a lot less relevant now that the generation basically can't detect invalid states, and make sure no logging appears without -d locationlists=2. Updates #25404 Change-Id: If3522df5a7397f2e7b43cb808936e319132132b6 Reviewed-on: https://go-review.googlesource.com/114007 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of Go are you using (
go version)?Tip (
go version devel +212c9479e3 Tue May 15 16:29:04 2018 +0000 darwin/amd64).Does this issue reproduce with the latest release?
No (tested 1.10.1).
What operating system and processor architecture are you using (
go env)?darwin/amd64, but probably a universal issue.What did you do?
go get -u golang.org/x/crypto
cd $GOPATH/src/golang.org/x/crypto/internal/chacha20
GOSSAFUNC=\(*Cipher\).XORKeyStream go test -c
What did you expect to see?
No extra output.
What did you see instead?
This appears to be generated by
go/src/cmd/compile/internal/ssa/debug.go
Line 480 in 212c947
The text was updated successfully, but these errors were encountered: