Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/sha3: add cSHAKE support #25395

Closed
kriskwiatkowski opened this issue May 15, 2018 · 5 comments
Closed

x/crypto/sha3: add cSHAKE support #25395

kriskwiatkowski opened this issue May 15, 2018 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@kriskwiatkowski
Copy link

The code for cSHAKE is now ready here https://go-review.googlesource.com/c/crypto/+/111281/

Is there any chance to merge it soon?
@FiloSottile FiloSottile changed the title sha3: add cSHAKE support x/crypto/sha3: add cSHAKE support May 15, 2018
@gopherbot gopherbot added this to the Unreleased milestone May 15, 2018
@FiloSottile
Copy link
Contributor

(This was approved in #24988.)

This week is the Go team summit so we are going to be a bit slow at reviewing, sorry about that.

@FiloSottile FiloSottile added the NeedsFix The path to resolution is known, but the work has not been done. label May 15, 2018
@kriskwiatkowski
Copy link
Author

Ok, thnx for update. No worries, have fun.

@odeke-em
Copy link
Member

I'll also page @veorq, if you get bored or have some free time, please feel free to take a look at the CL above posted :)

@kriskwiatkowski
Copy link
Author

Hi, is there something I can do, so that it can get merged?

@kriskwiatkowski
Copy link
Author

kriskwiatkowski commented Apr 17, 2019 •
edited

This is now done:
https://go-review.googlesource.com/c/crypto/+/111281/

FiloSottile pushed a commit to FiloSottile/go that referenced this issue Nov 24, 2019
@FiloSottile
sha3: add cSHAKE support
f416eba 
This patch implements 128- and 256-bit version of customizable variant
of SHAKE function (cSHAKE).

* Implementation based on NIST FIPS 202
* Test data file has been updated with cSHAKE KATs. I've copied
  examples from NIST document available here:
  https://csrc.nist.gov/csrc/media/projects/cryptographic-standards-and
  -guidelines/documents/examples/cshake_samples.pdf

Fixes golang#25395

Change-Id: Icbbc4232f3d9a28b3d6ead51937c2e60c00e5d8c
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/111281
Reviewed-by: Filippo Valsorda <filippo@golang.org>
@golang golang locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@kriskwiatkowski @FiloSottile @odeke-em @gopherbot