strings: QEncodeWord benchmark regression due to strings.Builder #25379
Labels
FrozenDueToAge
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
release-blocker
Milestone
Compared with go1.10.2, tip shows performance regression in
mime
:Change that affected it: CL102479/encodedword.go
sync.Pool
+bytes.Buffer
are replaced withstrings.Builder
.I've changed
strings.Builder
tobytes.Buffer
again, without using pool (and by the way, it was on different machine, so this issue is reproducible on both server and desktop hardware):The results are more noisy on my laptop, but the delta still stands.
cpuprofiles:
memprofiles:
I haven't found any open
strings.Builder
performance issues.My understanding is that
strings.Builder
is intended to be at least on par withbytes.Buffer
, preferably even faster.If this slowdown is expected and acceptable, this issue can be closed right away.
The text was updated successfully, but these errors were encountered: