Wonder how the try-bots passed this.

Maybe this test is not run by try-bots?

% go test -short go/types
ok  	go/types	0.370s

That's right. Try-bots just run -short tests if I am not mistaken.

I was under the impression that Go's pprof vendor wouldn't use readline, so we wouldn't have to pull it in as a dependency. If so, this is hopefully just a mistake with an easy fix.

We don't use the file, so we can delete it.

We should come up with a strategy to keep this from happening again, though. Even if the go/types test gets run by the builders, it wouldn't be part of the trybots, so I'm sure that the file would get re-added sooner than later.

If we were using a dependency management tool, this would be trivial - it's a main package, so it should not be vendored. Perhaps a better short-term solution is to add src/cmd/vendor/github.com/google/pprof/*.go to some gitignore file.

Change https://golang.org/cl/113295 mentions this issue: cmd/vendor/.../pprof: delete pprof.go file

Currently there is no formal procedure to update this, so I will just write a script for update.

Do you mean that vendor.json has been getting updated manually? I assumed that it was done with a tool like govendor, but I failed to get that one to work properly.