Change https://golang.org/cl/107935 mentions this issue: runtime/race: implement race detector for ppc64le

The test tries to send a message to its PID minus one and expect it to not have permissions? But we're root now (unlike our fake root in Kubernetes before), so we do have permissions, but the PID-minus-one just doesn't exist?

                var ucred unix.Ucred
                ucred.Pid = int32(os.Getpid() - 1)
                ucred.Uid = uint32(os.Getuid())
                ucred.Gid = uint32(os.Getgid())
                oob := unix.UnixCredentials(&ucred)
                _, _, err = cli.(*net.UnixConn).WriteMsgUnix(nil, oob, nil)
                if op, ok := err.(*net.OpError); ok {
                        err = op.Err
                }
                if sys, ok := err.(*os.SyscallError); ok {
                        err = sys.Err
                }
                if err != syscall.EPERM {
                        t.Fatalf("WriteMsgUnix failed with %v, want EPERM", err)
                }

@hugelgupf, can you help us fix this failing test?

We moved Go's builders from Kubernetes pods to privileged Docker containers under GCE Contained-Optimized OS and now there are behavior differences in this test you added in golang/sys@f67933e

Thanks!

Now that you are root, the test is somewhat moot. Both before and after I made that change, you were looking to elicit EPERM from the kernel -- once you have all capabilities, that's not going to happen. Essentially, you are testing the syscall here, not the Go logic.

You could add some logic where you spawn a new thread, lock it to an OS thread, drop capabilities and change user ID (just on the thread by doing syscall.Syscall(SYS_SETUID), not the POSIX-compliant thing that changes all threads), and then try to elicit EPERM -- but I would say it's not really worth it unless you are trying to test the syscall itself.

My 2c: just delete it.

Change https://golang.org/cl/112738 mentions this issue: unix: fix TestSCMCredentials to not fail when root

@hugelgupf, SGTM. I sent https://go-review.googlesource.com/#/c/sys/+/112738 ... care to review?