You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
/build/linux/types.go:980:19: could not determine kind of name for C.ST_MANDLOCK
/build/linux/types.go:981:19: could not determine kind of name for C.ST_NOATIME
/build/linux/types.go:982:19: could not determine kind of name for C.ST_NODEV
/build/linux/types.go:983:19: could not determine kind of name for C.ST_NODIRATIME
/build/linux/types.go:984:19: could not determine kind of name for C.ST_NOEXEC
/build/linux/types.go:985:19: could not determine kind of name for C.ST_NOSUID
/build/linux/types.go:986:19: could not determine kind of name for C.ST_RDONLY
/build/linux/types.go:987:19: could not determine kind of name for C.ST_RELATIME
/build/linux/types.go:988:19: could not determine kind of name for C.ST_SYNCHRONOUS
/* * Definitions for the flag in f_flag. * * Generally these flags are equivalent to the MS_ flags used in the mount * ABI. The exception is ST_VALID which has the same value as MS_REMOUNT * which doesn't make any sense for statfs. */#defineST_RDONLY 0x0001 /* mount read-only */
#defineST_NOSUID 0x0002 /* ignore suid and sgid bits */
#defineST_NODEV 0x0004 /* disallow access to device special files */
#defineST_NOEXEC 0x0008 /* disallow program execution */
...
And I discovered we do have MS_NOEXEC, so that'll do for now.
But it'd be nice to also have the ST_ names in there, even if they're the same. It would save others this distraction in the future.
It seems sys/vfs.h doesn't include bits/statvfs. (or sys/statvfs.h for that matter) where these constants are defined. Replacing #include <sys/vfs.h> with #include <sys/statvfs.h> seems to do the trick. I'll send a CL, also adding the *_MAGIC constants.
I needed the ST_NOEXEC constant for statfs, but found it missing in x/sys/unix.
I tried the obvious,
but I got:
I then went to search how they were defined and found https://elixir.bootlin.com/linux/latest/source/include/linux/statfs.h#L33
And I discovered we do have MS_NOEXEC, so that'll do for now.
But it'd be nice to also have the ST_ names in there, even if they're the same. It would save others this distraction in the future.
/cc @tklauser
The text was updated successfully, but these errors were encountered: