Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: DB documentation should mention DB.Conn() #25330

Closed
AlekSi opened this issue May 10, 2018 · 2 comments
Closed

database/sql: DB documentation should mention DB.Conn() #25330

AlekSi opened this issue May 10, 2018 · 2 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unplanned

Comments

@AlekSi
Copy link
Contributor

AlekSi commented May 10, 2018

https://golang.org/pkg/database/sql/#DB currently states:

If the database has a concept of per-connection state, such state can only be reliably observed within a transaction.

This is no longer true: DB.Conn() was added to allow one to have a per-connection state without using transactions. DB documentation should be updated.
@gopherbot gopherbot added the Documentation Issues describing a change to documentation. label May 10, 2018
@kardianos
Copy link
Contributor

Sounds good

@ianlancetaylor ianlancetaylor added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels May 31, 2018
@ianlancetaylor ianlancetaylor added this to the Unplanned milestone May 31, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/116596 mentions this issue: database: update doc related to per-connaction state

@golang golang locked and limited conversation to collaborators Jun 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@AlekSi @kardianos @ianlancetaylor @gopherbot