Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/cache: remove $GOCACHE/log.txt #25323

Closed
mattn opened this issue May 10, 2018 · 7 comments
Closed

cmd/go/internal/cache: remove $GOCACHE/log.txt #25323

mattn opened this issue May 10, 2018 · 7 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.13

Comments

@mattn
Copy link
Member

mattn commented May 10, 2018

In my $GOCACHE, file size of my log.txt is 5.7MB. Current implementation doesn't take care the size of log.txt. Some environment possibly have more large log file. How about to add a way to remove or rotating log file?
@ianlancetaylor ianlancetaylor added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels May 10, 2018
@ianlancetaylor ianlancetaylor added this to the Go1.11 milestone May 10, 2018
@ianlancetaylor
Copy link
Contributor

CC @rsc

@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.12 Jun 14, 2018
@japettyjohn
Copy link

I can confirm the possibility of a large file - I ran into one being 12 gigs and stretching back 4 months. This could be addressed either in the go clean -cache routine in clean.go or added as another flag there, e.g. go clean -cacheLog.

@gopherbot
Copy link

Change https://golang.org/cl/150797 mentions this issue: cmd/go/internal/cache: remove cache logs if -cacheLog flag is set

@FiloSottile
Copy link
Contributor

Mine is 451M, while the rest of the cache is 20M. I think we should limit its size automatically, not only when a specific "go clean" command is run.

@FiloSottile FiloSottile added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. and removed release-blocker labels Jan 2, 2019
@gopherbot gopherbot removed the NeedsFix The path to resolution is known, but the work has not been done. label Jan 2, 2019
@bradfitz
Copy link
Contributor

bradfitz commented Jan 7, 2019

It's pretty late to add new command line flags to cmd/go.

Bumping to Go 1.13.

@bradfitz bradfitz modified the milestones: Go1.12, Go1.13 Jan 7, 2019
@rsc
Copy link
Contributor

rsc commented Jan 8, 2019

We added this file in order to help evaluate the automatic cache expiry policy. It was important for that purpose that go clean not delete it. But I think we're quite happy with the automatic cache expiry policy - certainly no one has complained - so I think we can just stop writing the file and also delete it during go clean -cache. But for Go 1.13, not Go 1.12. Thanks.

@FiloSottile FiloSottile added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Jan 8, 2019
@gopherbot gopherbot removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jan 8, 2019
@FiloSottile FiloSottile changed the title cmd/go/internal/cache: remove old logs in $GOCACHE/log.txt cmd/go/internal/cache: remove $GOCACHE/log.txt Jan 8, 2019
@bcmills bcmills self-assigned this Mar 15, 2019
@gopherbot
Copy link

Change https://golang.org/cl/167741 mentions this issue: cmd/go/internal/cache: remove log.txt from the cache directory

@bradfitz bradfitz mentioned this issue Mar 27, 2019
Closed
@golang golang locked and limited conversation to collaborators Mar 14, 2020
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
8 participants
@bradfitz @mattn @rsc @FiloSottile @japettyjohn @ianlancetaylor @bcmills @gopherbot