Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile: consider androidstudio gobind plugin retirement #25314

Closed
hyangah opened this issue May 9, 2018 · 3 comments
Closed

x/mobile: consider androidstudio gobind plugin retirement #25314

hyangah opened this issue May 9, 2018 · 3 comments
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented May 9, 2018

Working with the gradle plugins is a pain, we have no active maintainer for this plugin.
The release process is not well-established (#14690).
Maintenance burden seems to outweigh the benefit.

Users can manually build the .aar file with gomobile and import the .aar file into the studio without the plugin.

@eliasnaur

@hyangah hyangah added the mobile Android, iOS, and x/mobile label May 9, 2018
@hyangah hyangah added this to the Unreleased milestone May 9, 2018
@hyangah hyangah changed the title mobile: consider androidstudio gobind plugin retirement x/mobile: consider androidstudio gobind plugin retirement May 9, 2018
@eliasnaur
Copy link
Contributor

I'm for this proposal.

What happens with the released plugin? If we don't delete it, users will mistakenly expect it to work and be supported.

@gopherbot
Copy link

Change https://golang.org/cl/141057 mentions this issue: misc,example/bind/hello: remove the Gradle plugin

zchee pushed a commit to zchee/golang-wiki that referenced this issue Jan 28, 2019
…aintainer: golang/go#25314. Users are probably better off without it.
@prep
Copy link

prep commented Aug 1, 2019

Apologies for commenting in a closed ticket, but it's a bit unclear to me how the plugin-specific functionality (like databinding and R/layout generation) from the plugin is replaced. Is there an alternative way to go about this, or should I consider the removal of the plugin and the reverse example as a hint that Android support via reverse bindings is being depreciated?

@golang golang locked and limited conversation to collaborators Jul 31, 2020
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 10, 2021
And replace the plugin with instructions for rebuilding the .aar files
for the bind and ivy examples.

While here, fix a compile error in the Ivy example caused by gomobile
no longer prepending org.golang. to its generated Java packages by
default.

Fixes golang/go#25314
Fixes golang/go#28098
Fixes golang/go#25184

Change-Id: Iaccdd50850a185414ebcf21427cfd7f625c6a298
Reviewed-on: https://go-review.googlesource.com/c/141057
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 11, 2021
And replace the plugin with instructions for rebuilding the .aar files
for the bind and ivy examples.

While here, fix a compile error in the Ivy example caused by gomobile
no longer prepending org.golang. to its generated Java packages by
default.

Fixes golang/go#25314
Fixes golang/go#28098
Fixes golang/go#25184

Change-Id: Iaccdd50850a185414ebcf21427cfd7f625c6a298
Reviewed-on: https://go-review.googlesource.com/c/141057
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile
Projects
None yet
Development

No branches or pull requests

4 participants