Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/salsa20: implement cipher.Stream interface #25308

Open
FiloSottile opened this issue May 9, 2018 · 2 comments
Open

x/crypto/salsa20: implement cipher.Stream interface #25308

FiloSottile opened this issue May 9, 2018 · 2 comments
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@FiloSottile
Copy link
Contributor

salsa20 is the odd one out that implements only a stateless XORKeyStream at the package level.
@FiloSottile FiloSottile added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels May 9, 2018
@FiloSottile FiloSottile added this to the Unreleased milestone May 9, 2018
@as
Copy link
Contributor

as commented May 11, 2018

The nonce is currently exposed to the user, how would the cipher.Stream interface modify the nonce? simple increment?

How does the constructor handle the semantics for the different salsa lengths?

@jannson
Copy link

jannson commented Sep 20, 2018

I implement an example here:
https://github.com/jannson/salsa20stream

You can read usage in example:
ver1: https://github.com/jannson/salsa20stream/blob/master/salsa20stream_test.go#L15
ver2: https://github.com/jannson/salsa20stream/blob/master/salsa20stream_test.go#L29

bench comparing with aes also in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@FiloSottile @jannson @as