-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: upgrade FreeBSD builders to avoid flakes #25289
Comments
I just ran this test on 12-CURRENT and 11.1-RELEASE-p4 and it passed. |
@ayang64 Thanks. To be clear, the test normally passes. As the message above suggests, it is only failing about 7.6% of the time. How many times did you run the test? |
I just tried 10000 times under 12-CURRNET (02bd6c4) and 12.0-CURRENT (58e53e526dc) and 500 under 11.1-RELEASE-p4 with no failures. |
Great, thanks! Changing this issue to upgrade our builders. |
CC @bradfitz |
Change https://golang.org/cl/127837 mentions this issue: |
Updates #25289 Change-Id: I662760b921be625aca988cd0b43c648ac5dfd814 Reviewed-on: https://go-review.googlesource.com/127837 Reviewed-by: Bryan C. Mills <bcmills@google.com> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Change https://golang.org/cl/135475 mentions this issue: |
FreeBSD people, is it reasonable to take down our 10.3 and 11.1 builders and replace them with 10.4 or 11.2? I'd rather not double the number of FreeBSD builder's we're running, but we could if necessary. I don't know what versions are important/commonly used in practice. /cc @dmitshur |
Use freebsd-update when preparing the downloaded -RELEASE image to get errata and security updates made since the release. Switch kern.timecounter.hardware from ACPI-safe to TSC on GCE https://lists.freebsd.org/pipermail/freebsd-cloud/2017-January/000080.html Drop vtnet hw.vtnet.csum_disable=1 workaround, should be fixed in all supported versions. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207446 Update the expect script to switch the console to serial, this makes it possible to match prompts via a regexp (11.2 has 'root@freebsd:~ #', while the older images are 'root@:~ #'). Otherwise qemu with -display curses emits ansi escape codes which make a mess of everything. This requires the sgabios smbios extension installed on the host preparing the images. https://code.google.com/archive/p/sgabios/ https://packages.ubuntu.com/xenial/sgabios SeaBIOS 1.11.0 and up should have a compatible rom builtin, but it's not even available in Ubuntu 18.04. qemu/seabios@d6728f3 Additionaly drop the -smp 2 directive for qemu, until MTTCG is enabled on amd64 targets. Updates golang/go#25289 Change-Id: If33c2b35b4221f27d719938bcfc013efe3549305 Reviewed-on: https://go-review.googlesource.com/135475 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Change https://golang.org/cl/138258 mentions this issue: |
@bradfitz our builders are horribly out of date, for eg. our 11.1 builder is 11.1-RELEASE and is missing around a year worth of security patches and updates (~15 of them). Unfortunately 11.1 is expected to receive EoL on the 30th of September, and 10.4 a month after that. I think we have no choice but to switch the 10.3-RELEASE to 10.4-RELEASE-p13. Maybe it's worth while having a 11.1 builder as well, but I'd rather we update it to 11.1-RELEASE-p15 if we'd need to test future Go 1.10/1.11 releases? |
Since 10.4 and 11.2 are currently supported releases (even though they're close to EoL), I think it is reasonable to bump up the revs used by the builders. It may also be helpful to start eyeing a 12.0 builder since it is due in Novemberish. It looks like there are a few system call/ABI changes in 12 that might need addressing. I wonder how incompatibilities across GOOS versions are handled. It might be useful to be able to target FreeBSD 11.x and FreeBSD 12.x as separate GOOS. |
Not yet the defaults or trybots until we see they're working regularly for a few days and compare timings, etc. Updates golang/go#25289 Change-Id: I4baed066b5f6d9f01e5454b716cacda4986620d0 Reviewed-on: https://go-review.googlesource.com/138258 Reviewed-by: Yuval Pavel Zholkover <paulzhol@gmail.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
That introduces a bunch of complexity which we don't want for ourselves or our users. Making it Just Work is much more preferred. |
@bradfitz I'm not sure if the kernel fix was added to 10.4 (I'll try to reproduce in a VM). If it's fixed, can we drop the 10.3 builder (and maybe the 11.1 one) for Go 1.12? |
Change https://golang.org/cl/155977 mentions this issue: |
Install GDB from the ports collection, the in-tree was removed from the base system in FreeBSD 12.0, and the older releases have an unsupported (6.1.1 or older version). Updates golang/go#25289 Change-Id: I8899a2a70c0b9ee9171621206431ca24a7e97704 Reviewed-on: https://go-review.googlesource.com/c/155977 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
I rebuilt the FreeBSD amd64 image with https://golang.org/cl/155977 & updated the coordinator from git rev 7b78c2042368d5c56ee9dbd92ab5fa988c763944 to 9730d8b657054ead7ffc67bfb2dff24b89a368a5 |
2018-05-01T14:50:33-7f6105f/freebsd-386-11_1
2018-05-01T18:22:06-a5b80d4/freebsd-amd64-11_1
2018-05-02T17:52:14-e8d417d/freebsd-amd64-11_1
2018-05-04T14:47:49-166c37a/freebsd-386-11_1
2018-05-05T00:53:45-2a7e19e/freebsd-amd64-11_1
2018-05-05T00:54:52-f7c767e/freebsd-amd64-11_1
2018-05-06T04:28:23-a8a60ac/freebsd-386-10_3
2018-05-08T13:29:22-b00f72e/freebsd-386-11_1
findflakes reports
The text was updated successfully, but these errors were encountered: