Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: misc/cgo/testcshared failure [1.10 backport] #25277

Closed
gopherbot opened this issue May 7, 2018 · 2 comments
Closed

build: misc/cgo/testcshared failure [1.10 backport] #25277

gopherbot opened this issue May 7, 2018 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.10.3

Comments

@gopherbot
Copy link

@FiloSottile requested issue #23784 to be considered for backport to the next 1.10 minor release.

@ianlancetaylor this breaks the trybots on the 1.10 release branch as well, and is probably (?) also an issue on 1.9, can you look into backporting the fix?

https://go-review.googlesource.com/c/go/+/111715#message-c7b7c5f6de1d1ad25c8c7db15599e99e29a392a7

@gopherbot please open a backport issue for 1.10 and 1.9.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 7, 2018
@gopherbot gopherbot mentioned this issue May 7, 2018
Closed
@gopherbot gopherbot added this to the Go1.10.3 milestone May 7, 2018
@gopherbot
Copy link
Author

Change https://golang.org/cl/111995 mentions this issue: [release-branch.go1.10] misc/cgo/testcshared: use file descriptor 30 for TestUnexportedSymbols

@gopherbot
Copy link
Author

Closed by merging 516f5cc to release-branch.go1.10.

gopherbot pushed a commit that referenced this issue May 8, 2018
@ianlancetaylor
[release-branch.go1.10] misc/cgo/testcshared: use file descriptor 30 …
516f5cc 
…for TestUnexportedSymbols

Backport of CL 108537 to 1.10 release branch.

We were using file descriptor 100, which requires the Linux kernel to
grow the fdtable size. That step may sometimes require a long time,
causing the test to fail. Switch to file descriptor 30, which should
not require growing the fdtable.

Updates #23784
Fixes #25277

Change-Id: I9d25986f3b59bdeb04aa52407b24aa94712aedff
Reviewed-on: https://go-review.googlesource.com/111995
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators May 8, 2019
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.10.3
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot