Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: remove wait-author on new patchset uploaded #25253

Closed
bradfitz opened this issue May 4, 2018 · 2 comments
Closed

x/build/cmd/gopherbot: remove wait-author on new patchset uploaded #25253

bradfitz opened this issue May 4, 2018 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@bradfitz
Copy link
Contributor

bradfitz commented May 4, 2018

gopherbot is supposed to remove the "wait-author" hashtag when the OP replies.

In this case it did not, because the OP is a GitHub PR, presumably:

https://go-review.googlesource.com/c/go/+/110561

Ideally we'd handle GitHub PRs better and know which Gerrit user == which GitHub user, but as a partial fix: at least handle new patchset uploads as meaning the OP replied too.

/cc @andybons @bcmills @FiloSottile

@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label May 4, 2018
@bradfitz bradfitz self-assigned this May 4, 2018
@gopherbot gopherbot added this to the Unreleased milestone May 4, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 4, 2018
@bradfitz bradfitz assigned dmitshur and unassigned bradfitz Aug 29, 2018
@bradfitz
Copy link
Contributor Author

We should move to the more conservative heuristic that ANY activity in Gerrit on the CL past the event (magic comment) that added the "wait-author" hashtag is potential OP activity and should remove wait-author.

@agnivade
Copy link
Contributor

agnivade commented Nov 8, 2018

Duplicate issue filed again at #28510. That has some more context. I will go ahead and close this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants