Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: Windows installer has scary prompt #25202

Closed
bradfitz opened this issue May 1, 2018 · 6 comments
Closed

release: Windows installer has scary prompt #25202

bradfitz opened this issue May 1, 2018 · 6 comments

Comments

@bradfitz
Copy link
Contributor

bradfitz commented May 1, 2018

I installed Go 1.10.1 on a Windows 10 machine, and a few clicks into the MSI installer, I get this prompt:

msi

What is "429812a4.msi" ?

Can we make that string something less sketchy looking?

/cc @andybons @alexbrainman

@alexbrainman
Copy link
Member

What is "429812a4.msi" ?

Good find. It does look scary. :-)

Alex

@agnivade
Copy link
Contributor

agnivade commented May 2, 2018

I want to add that if you go to https://golang.org there is no link to an "download" or install section.

There is a big "Download Go" button on the page.

Let us keep the discussion on the actual issue and not add extra noise.

@fgergo
Copy link

fgergo commented May 30, 2018

@bradfitz I believe it's this:
https://stackoverflow.com/questions/6863137/odd-program-name-when-installing-signed-msi-installer

I could not find where signing is done in github.com/golang, maybe it's done somewhere else?
(wix isn't doing it in github.com/golang/build/tree/master/cmd/release/releaselet.go )

This should work:
c:>signtool.exe /d "Your Software Name"

@alexbrainman
Copy link
Member

I believe it's this:
https://stackoverflow.com/questions/6863137/odd-program-name-when-installing-signed-msi-installer

Looks very similar, indeed. Thank you.

I could not find where signing is done in github.com/golang, maybe it's done somewhere else?
(wix isn't doing it in github.com/golang/build/tree/master/cmd/release/releaselet.go )

Same. I could not find signing code. I suspect it is done manually.

This should work:
c:>signtool.exe /d "Your Software Name"

Maybe @bradfitz or @andybons can help.

Alex

@fgergo
Copy link

fgergo commented Jun 23, 2018

@bradfitz @andybons Do you need anything else?

@andybons
Copy link
Member

andybons commented Aug 2, 2018

OK. In future releases we will have a non-shady-looking install prompt:
249ad22f-ce1c-4a31-bddb-2d0957431762

@andybons andybons closed this as completed Aug 2, 2018
@golang golang locked and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants